-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Forwardport] fixed Quote Item Prices are NULL in cart related events. #18685 #23839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
magento-engcom-team
merged 8 commits into
magento:2.3-develop
from
edenduong:2.3-develop-PR-port-18808
Aug 14, 2019
Merged
[Forwardport] fixed Quote Item Prices are NULL in cart related events. #18685 #23839
magento-engcom-team
merged 8 commits into
magento:2.3-develop
from
edenduong:2.3-develop-PR-port-18808
Aug 14, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward Port From 2.2 to 2.3 |
swnsma
approved these changes
Jul 31, 2019
Hi @swnsma, thank you for the review.
|
✔️ QA passed |
Hi @edenduong, thank you for your contribution! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Auto-Tests: Covered
All changes in Pull Request is covered by auto-tests
Component: Quote
Progress: accept
Release Line: 2.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#18808
Description (*)
before these two observers checkout_cart_product_add_after, checkout_cart_product_update_after cart item is not saved into the database the object is only created and in the object price was not set but custom price was set so there was no issue of custom price, we could have added the price in the item from two files:
app/code/Magento/Quote/Model/Quote/Item/Processor.php and
app/code/Magento/Quote/Model/Quote.php
I have added the price in this file app/code/Magento/Quote/Model/Quote/Item/Processor.php
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)