Replaced ArrayInterface with OptionSourceInterface

[sreichel]

Description (*)

lib\internal\Magento\Framework\Option\ArrayInterface.php

/**
 * @todo Remove in favor of the ancestor interface
 */
interface ArrayInterface extends \Magento\Framework\Data\OptionSourceInterface

Replaced all occurrences and marked ArrayInterface as deprecated.

Fixed Issues (if relevant)

1. n/a

Manual testing scenarios (*)

1. n/a

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @sreichel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sivaschenko]

Considering that theoretically, this is backward incompatible change, probably it would be better to mark the interface as deprecated first. However, I think it is very unlikely that ArrayInterface is used as a parameter type anywhere. Added this pull request to discuss at a group code review.

[sreichel]

@sivaschenko Thanks for reply, I've not removed the interface. It marked as deprecated and not used in core. Should not break anything. (?)

[sivaschenko]

@sreichel I.e. it will break code where:

• there is a method that accepts a parameter of type ArrayInterface,
• and this method is called passing an instance of a class that was implementing ArrayInterface before this pull request (but does not implement anymore).

[sivaschenko]

Hi @sreichel we had a group code review session today discussing this pull request, we decided that is will be unsafe to replace the interface on this stage. It's ok to mark the interface as deprecated for now. Then after a couple of releases with it being deprecated, it will be ok to replace it.

[sreichel]

@sivaschenko is it OK to set @decreacted via internal ticket?

[sivaschenko]

@sreichel I am not sure about internal tickets, you can do it in this pull request as I think anyway this pull request will have to be recreated by the time it will be OK to deliver it.

[sivaschenko]

@sreichel the pull request is put on hold. Please open another pull request with a link to this one where an interface is marked as deprecated

[sivaschenko]

It is necessary to deprecate the interface before removing it from inheritance hierarchy. This pull request will be processed a couple of releases after #19601 is merged

[orlangur]

@sivaschenko are you sure it can be processed earlier than 2.4-develop?

[sivaschenko]

@orlangur In my opinion it can be processed earlier, however, no, I am not sure.

[orlangur]

@sivaschenko keeping open pull request is not a proper way to track necessary changes. Please report internal ticket targeting 2.4-develop describing necessary changes instead.

[m2-assistant]

Hi @sreichel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[orlangur]

Changed my mind.

[sivaschenko]

Hi @sreichel , we are going to resume processing of this pull request.

Can you please update your branch, resolve conflicts and ensure all tests are passing

[sivaschenko]

The pull request is approved to be merged to 2.4 at magento/architecture#174 including the removal of ArrayInterface

[sreichel]

I'll update for 2.4.

[ihor-sviziev]

Hi @sreichel,
Branch 2.4-develop was already created and this PR was re-targeted into it. Could you update your PR and resolve merge conflicts?

[ihor-sviziev]

Hi @sreichel,
Will you be able to update your PR?

[ihor-sviziev]

@sreichel I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[m2-assistant]

Hi @sreichel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.