Skip to content

Deprecated ArrayInterface in favour of ancestor OptionSourceInterface #19601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2018
Merged

Deprecated ArrayInterface in favour of ancestor OptionSourceInterface #19601

merged 2 commits into from
Dec 9, 2018

Conversation

sivaschenko
Copy link
Member

Description (*)

Marked Magento\Framework\Option\ArrayInterface as deprecated in favour of ancestor Magento\Framework\Data\OptionSourceInterface
Please see #19308 with further replacements

Fixed Issues (if relevant)

n/a

Manual testing scenarios (*)

n/a

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3630 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@sivaschenko sivaschenko deleted the deprecated-array-interface branch March 26, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants