Skip to content

[Forwardport] Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products. Use configurable product`s children for shopping cart rules validation for cases when attribute exists for children only (E.g. special_price) #19342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nmalevanec
Copy link
Contributor

Original Pull Request

#16342

Use configurable product`s children for shopping cart rules validation
for cases when attribute exists for children only (E.g. special_price)

Description

Fixed Issues (if relevant)

  1. Cart Sales Rule with negated condition over special_price does not work for configurable products #14020 Cart Sales Rule with negated condition over special_price does not work for configurable products

Manual testing scenarios

  1. Enable the special_price for promo rule conditions:
    1. Stores > Attributes > Product
    2. Search for and edit special_price
    3. Storefront Properties: Use for Promo Rule Conditions: Yes
    4. Save
  2. create new cart sales rule:
    1. Marketing > Cart Price Rules
    2. Add New Rule:
      1. Rule name = "Special Price Test"
      2. Website: select all
      3. Customer Groups: select all
      4. Coupon: "Specific Coupon"
      5. Coupon Code: "special"
      6. Actions: Discount Amount: "10"
      7. Actions: Apply the rule only to cart items matching the following conditions: "if ALL of these conditions are FALSE": "Special Price greater than 0.01"
      8. Leave all other fields to their defaults and save
  3. In the front end, add a the child product of a configurable product to the cart, such that the child product has a special price set. This product should be the only one in the cart.
  4. "View and Edit Cart" > "Apply Discount Code": special

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…e-does-not-work-for-configurable-products. Use configurable product`s children for shopping cart rules validation for cases when attribute exists for children only (E.g. special_price)
@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nmalevanec nmalevanec changed the title [Forwardport]Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products. Use configurable product`s children for shopping cart rules validation for cases when attribute exists for children only (E.g. special_price) [Forwardport] Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products. Use configurable product`s children for shopping cart rules validation for cases when attribute exists for children only (E.g. special_price) Nov 22, 2018
@nmalevanec nmalevanec closed this Nov 22, 2018
@nmalevanec nmalevanec deleted the 2.3-develop-PR-port-16342 branch November 22, 2018 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants