#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does… #16342

novikor · 2018-06-22T14:55:45Z

…-not-work-for-configurable-products.

Use configurable product`s children for shopping cart rules validation
for cases when attribute exists for children only (E.g. special_price)

Description

Fixed Issues (if relevant)

Cart Sales Rule with negated condition over special_price does not work for configurable products #14020 Cart Sales Rule with negated condition over special_price does not work for configurable products

Manual testing scenarios

Enable the special_price for promo rule conditions:
1. Stores > Attributes > Product
2. Search for and edit special_price
3. Storefront Properties: Use for Promo Rule Conditions: Yes
4. Save
create new cart sales rule:
1. Marketing > Cart Price Rules
2. Add New Rule:
  1. Rule name = "Special Price Test"
  2. Website: select all
  3. Customer Groups: select all
  4. Coupon: "Specific Coupon"
  5. Coupon Code: "special"
  6. Actions: Discount Amount: "10"
  7. Actions: Apply the rule only to cart items matching the following conditions: "if ALL of these conditions are FALSE": "Special Price greater than 0.01"
  8. Leave all other fields to their defaults and save
In the front end, add a the child product of a configurable product to the cart, such that the child product has a special price set. This product should be the only one in the cart.
"View and Edit Cart" > "Apply Discount Code": special

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

…ce-does-not-work-for-configurable-products. Use configurable product`s children for shopping cart rules validation for cases when attribute exists for children only (E.g. special_price)

magento-cicd2 · 2018-06-22T14:55:48Z

All committers have signed the CLA.

magento-engcom-team · 2018-06-22T14:55:49Z

Hi @novikor. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

phoenix128

Hello @novikor ,
thank you for your contribution.
We appreciate your support.

magento-engcom-team · 2018-06-23T09:49:45Z

Hi @phoenix128, thank you for the review.
ENGCOM-2111 has been created to process this Pull Request

novikor · 2018-06-30T10:24:43Z

@phoenix128 , please revert d2a0de8

This functionality have been implemented for configurable products only, not for all composite types.

Moreover, Unit tests will not fail if this commit is reverted.

Thank you.

sidolov · 2018-07-03T06:10:49Z

app/code/Magento/SalesRule/Model/Rule/Condition/Product.php

+     * @return \Magento\Catalog\Api\Data\ProductInterface|\Magento\Catalog\Model\Product
+     * @throws \Magento\Framework\Exception\NoSuchEntityException
+     */
+    protected function getProductToValidate(\Magento\Framework\Model\AbstractModel $model)


Please, make this method private

Done, please review: fae98c0 & 9a35b45

…ce-does-not-work-for-configurable-products. Revert "Removed dependency to configurable product" This reverts commit d2a0de8.

…ce-does-not-work-for-configurable-products. Made getProductToValidate method private according to Technical Guideline (2.7)

…ce-does-not-work-for-configurable-products. Added configurable product to dependencies

novikor · 2018-07-16T07:12:43Z

@sidolov , are there any updates?

sidolov · 2018-07-17T06:20:55Z

Hi @novikor , we are trying to avoid new dependencies across Magento modules and define another one it's not a good idea. If you have the specific case for the configurable product during the rule processing it would be better to use default Magento ways for extensibility (plugins, DI configuration, etc).

…cial-price-does-not-work-for-configurable-products. Added configurable product to dependencies" This reverts commit 887ee4a

…gated-condition-over-special-price-does-not-work-for-configurable-products # Conflicts: # app/code/Magento/SalesRule/Model/Rule/Condition/Product.php

…ce-does-not-work-for-configurable-products. Restored \Magento\SalesRule\Model\Rule\Condition\Product to its previous state except PHPDocs.

sidolov · 2018-07-27T13:33:19Z

app/code/Magento/ConfigurableProduct/Plugin/SalesRule/Model/Rule/Condition/Product.php

+{
+    /**
+     * @param \Magento\SalesRule\Model\Rule\Condition\Product $subject
+     * @param \Magento\Framework\Model\AbstractModel          $model


Please, remove extra spaces

sidolov · 2018-07-27T13:33:33Z

app/code/Magento/ConfigurableProduct/Plugin/SalesRule/Model/Rule/Condition/Product.php

+
+    /**
+     * @param \Magento\SalesRule\Model\Rule\Condition\Product $subject
+     * @param \Magento\Framework\Model\AbstractModel          $model


Please, remove extra spaces

sidolov · 2018-07-27T13:34:54Z

app/code/Magento/ConfigurableProduct/Plugin/SalesRule/Model/Rule/Condition/Product.php

@@ -0,0 +1,53 @@
+<?php declare(strict_types=1);


Please, cover new code at least by the unit test. It would be great if scenario will be covered with integration test

Unit tests coverage have been implemented.
@sidolov, please check.

…Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products

…th-negated-condition-over-special-price-does-not-work-for-configurable-products' into magento#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products

…ce-does-not-work-for-configurable-products. Unit tests coverage: case when child should be used

…ce-does-not-work-for-configurable-products. Fixed mock objects comparison

…ce-does-not-work-for-configurable-products. Fixed static tests.

…Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products

novikor · 2018-10-05T20:01:52Z

@sidolov , any updates?

sidolov · 2018-10-08T15:50:50Z

Hi @novikor , we found the problems with this solution on the B2B edition and trying to figure it out right now.
Thank you for your patience.

…al-price-does… #16342

magento-engcom-team · 2018-11-21T14:22:05Z

Hi @novikor. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

magento#14020-Cart-Sales-Rule-with-negated-condition-over-special-pri…

90b6803

…ce-does-not-work-for-configurable-products. Use configurable product`s children for shopping cart rules validation for cases when attribute exists for children only (E.g. special_price)

magento-engcom-team added the Component: SalesRule label Jun 22, 2018

phoenix128 self-assigned this Jun 22, 2018

phoenix128 approved these changes Jun 23, 2018

View reviewed changes

magento-engcom-team added this to the Release: 2.2.6 milestone Jun 23, 2018

magento-engcom-team added the Release Line: 2.2 label Jun 23, 2018

phoenix128 added 2 commits June 25, 2018 22:19

Removed empty line due to failing static test

2717cb1

Removed dependency to configurable product

d2a0de8

phoenix128 requested a review from sidolov June 26, 2018 14:26

sidolov requested changes Jul 3, 2018

View reviewed changes

novikor added 2 commits July 4, 2018 22:55

magento#14020-Cart-Sales-Rule-with-negated-condition-over-special-pri…

fae98c0

…ce-does-not-work-for-configurable-products. Revert "Removed dependency to configurable product" This reverts commit d2a0de8.

magento#14020-Cart-Sales-Rule-with-negated-condition-over-special-pri…

9a35b45

…ce-does-not-work-for-configurable-products. Made getProductToValidate method private according to Technical Guideline (2.7)

novikor added the Partner: ISM eCompany Pull Request is created by partner ISM eCompany label Jul 6, 2018

novikor assigned sidolov and unassigned phoenix128 Jul 7, 2018

magento#14020-Cart-Sales-Rule-with-negated-condition-over-special-pri…

887ee4a

…ce-does-not-work-for-configurable-products. Added configurable product to dependencies

novikor assigned novikor and unassigned sidolov Jul 22, 2018

novikor added 3 commits July 22, 2018 12:30

Revert "magento#14020-Cart-Sales-Rule-with-negated-condition-over-spe…

0c9aa81

…cial-price-does-not-work-for-configurable-products. Added configurable product to dependencies" This reverts commit 887ee4a

Merge branch '2.2-develop' into magento#14020-Cart-Sales-Rule-with-ne…

4e68337

…gated-condition-over-special-price-does-not-work-for-configurable-products # Conflicts: # app/code/Magento/SalesRule/Model/Rule/Condition/Product.php

magento#14020-Cart-Sales-Rule-with-negated-condition-over-special-pri…

5b95b22

…ce-does-not-work-for-configurable-products. Restored \Magento\SalesRule\Model\Rule\Condition\Product to its previous state except PHPDocs.

novikor added the partners-contribution Pull Request is created by Magento Partner label Jul 22, 2018

Moved adjustments to plugin.

618f408

novikor force-pushed the #14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products branch from c1a780e to 618f408 Compare July 22, 2018 20:10

sidolov requested changes Jul 27, 2018

View reviewed changes

magento-engcom-team added the Progress: needs update label Aug 5, 2018

novikor assigned novikor and unassigned sidolov Aug 9, 2018

novikor added 4 commits August 9, 2018 13:24

Merge remote-tracking branch 'upstream/2.2-develop' into magento#14020-…

e7130bf

…Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products

Merge remote-tracking branch 'origin/magento#14020-Cart-Sales-Rule-wi…

5a7e78a

…th-negated-condition-over-special-price-does-not-work-for-configurable-products' into magento#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products

magento#14020-Cart-Sales-Rule-with-negated-condition-over-special-pri…

8d417ac

…ce-does-not-work-for-configurable-products. Unit tests coverage: case when child should be used

magento#14020-Cart-Sales-Rule-with-negated-condition-over-special-pri…

90ff989

…ce-does-not-work-for-configurable-products. Fixed mock objects comparison

novikor force-pushed the #14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products branch from 02bf4e0 to 870faf1 Compare August 9, 2018 14:01

Covered case when simple product is being validated

c52e0e8

novikor force-pushed the #14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products branch from 870faf1 to c52e0e8 Compare August 9, 2018 14:02

magento#14020-Cart-Sales-Rule-with-negated-condition-over-special-pri…

5c3154b

…ce-does-not-work-for-configurable-products. Fixed static tests.

novikor assigned sidolov and unassigned novikor Aug 10, 2018

Merge remote-tracking branch 'upstream/2.2-develop' into magento#14020-…

51adb9d

…Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products

magento-engcom-team modified the milestones: Release: 2.2.6, Release: 2.2.7 Aug 13, 2018

magento-engcom-team added the Component: ConfigurableProduct label Aug 13, 2018

sidolov removed the Progress: needs update label Sep 7, 2018

magento-engcom-team added the Progress: accept label Sep 7, 2018

VladimirZaets mentioned this pull request Nov 21, 2018

Cart Sales Rule with negated condition over special_price does not work for configurable products #14020

Closed

magento-engcom-team merged commit 51adb9d into magento:2.2-develop Nov 21, 2018

magento-engcom-team pushed a commit that referenced this pull request Nov 21, 2018

ENGCOM-2111: #14020-Cart-Sales-Rule-with-negated-condition-over-speci…

16f1eef

…al-price-does… #16342

magento-engcom-team added Award: bug fix Award: test coverage labels Nov 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does… #16342

#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does… #16342

novikor commented Jun 22, 2018

magento-cicd2 commented Jun 22, 2018 •

edited

Loading

magento-engcom-team commented Jun 22, 2018

phoenix128 left a comment

magento-engcom-team commented Jun 23, 2018

novikor commented Jun 30, 2018

sidolov Jul 3, 2018

novikor Jul 4, 2018

novikor commented Jul 16, 2018

sidolov commented Jul 17, 2018 •

edited

Loading

sidolov Jul 27, 2018

sidolov Jul 27, 2018

sidolov Jul 27, 2018

novikor Aug 10, 2018 •

edited

Loading

novikor commented Oct 5, 2018

sidolov commented Oct 8, 2018

magento-engcom-team commented Nov 21, 2018

#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does… #16342

#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does… #16342

Conversation

novikor commented Jun 22, 2018

Description

Fixed Issues (if relevant)

Manual testing scenarios

Contribution checklist

magento-cicd2 commented Jun 22, 2018 • edited Loading

magento-engcom-team commented Jun 22, 2018

phoenix128 left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Jun 23, 2018

novikor commented Jun 30, 2018

sidolov Jul 3, 2018

Choose a reason for hiding this comment

novikor Jul 4, 2018

Choose a reason for hiding this comment

novikor commented Jul 16, 2018

sidolov commented Jul 17, 2018 • edited Loading

sidolov Jul 27, 2018

Choose a reason for hiding this comment

sidolov Jul 27, 2018

Choose a reason for hiding this comment

sidolov Jul 27, 2018

Choose a reason for hiding this comment

novikor Aug 10, 2018 • edited Loading

Choose a reason for hiding this comment

novikor commented Oct 5, 2018

sidolov commented Oct 8, 2018

magento-engcom-team commented Nov 21, 2018

magento-cicd2 commented Jun 22, 2018 •

edited

Loading

sidolov commented Jul 17, 2018 •

edited

Loading

novikor Aug 10, 2018 •

edited

Loading