-
Notifications
You must be signed in to change notification settings - Fork 9.4k
#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does… #16342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
magento-engcom-team
merged 18 commits into
magento:2.2-develop
from
novikor:#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does-not-work-for-configurable-products
Nov 21, 2018
Merged
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
90b6803
#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does…
novikor 2717cb1
Removed empty line due to failing static test
phoenix128 d2a0de8
Removed dependency to configurable product
phoenix128 fae98c0
#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does…
novikor 9a35b45
#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does…
novikor 887ee4a
#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does…
novikor 0c9aa81
Revert "#14020-Cart-Sales-Rule-with-negated-condition-over-special-pr…
novikor 4e68337
Merge branch '2.2-develop' into #14020-Cart-Sales-Rule-with-negated-c…
novikor 5b95b22
#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does…
novikor 618f408
Moved adjustments to plugin.
novikor 7c8482b
#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does…
novikor e7130bf
Merge remote-tracking branch 'upstream/2.2-develop' into #14020-Cart-…
novikor 5a7e78a
Merge remote-tracking branch 'origin/#14020-Cart-Sales-Rule-with-nega…
novikor 8d417ac
#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does…
novikor 90ff989
#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does…
novikor c52e0e8
Covered case when simple product is being validated
novikor 5c3154b
#14020-Cart-Sales-Rule-with-negated-condition-over-special-price-does…
novikor 51adb9d
Merge remote-tracking branch 'upstream/2.2-develop' into #14020-Cart-…
novikor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,8 @@ | |
* Product rule condition data model | ||
* | ||
* @author Magento Core Team <[email protected]> | ||
* | ||
* @method string getAttribute() | ||
*/ | ||
class Product extends \Magento\Rule\Model\Condition\Product\AbstractProduct | ||
{ | ||
|
@@ -26,20 +28,47 @@ protected function _addSpecialAttributes(array &$attributes) | |
$attributes['quote_item_row_total'] = __('Row total in cart'); | ||
} | ||
|
||
/** | ||
* @param \Magento\Framework\Model\AbstractModel $model | ||
* | ||
* @return \Magento\Catalog\Api\Data\ProductInterface|\Magento\Catalog\Model\Product | ||
* @throws \Magento\Framework\Exception\NoSuchEntityException | ||
*/ | ||
protected function getProductToValidate(\Magento\Framework\Model\AbstractModel $model) | ||
{ | ||
/** @var \Magento\Catalog\Model\Product $product */ | ||
$product = $model->getProduct(); | ||
if (!$product instanceof \Magento\Catalog\Model\Product) { | ||
$product = $this->productRepository->getById($model->getProductId()); | ||
} | ||
|
||
$attrCode = $this->getAttribute(); | ||
|
||
/* Check for attributes which are not available for configurable products */ | ||
if ($product->isComposite() && !$product->hasData($attrCode)) { | ||
/** @var \Magento\Catalog\Api\Data\ProductInterface $childProduct */ | ||
$childProduct = current($model->getChildren())->getProduct(); | ||
if ($childProduct->hasData($attrCode)) { | ||
$product = $childProduct; | ||
} | ||
} | ||
|
||
return $product; | ||
} | ||
|
||
/** | ||
* Validate Product Rule Condition | ||
* | ||
* @param \Magento\Framework\Model\AbstractModel $model | ||
* | ||
* @return bool | ||
* @throws \Magento\Framework\Exception\NoSuchEntityException | ||
*/ | ||
public function validate(\Magento\Framework\Model\AbstractModel $model) | ||
{ | ||
//@todo reimplement this method when is fixed MAGETWO-5713 | ||
/** @var \Magento\Catalog\Model\Product $product */ | ||
$product = $model->getProduct(); | ||
if (!$product instanceof \Magento\Catalog\Model\Product) { | ||
$product = $this->productRepository->getById($model->getProductId()); | ||
} | ||
$product = $this->getProductToValidate($model); | ||
|
||
$product->setQuoteItemQty( | ||
$model->getQty() | ||
|
@@ -49,9 +78,7 @@ public function validate(\Magento\Framework\Model\AbstractModel $model) | |
$model->getBaseRowTotal() | ||
); | ||
|
||
$attrCode = $this->getAttribute(); | ||
|
||
if ('category_ids' == $attrCode) { | ||
if ('category_ids' == $this->getAttribute()) { | ||
return $this->validateAttribute($this->_getAvailableInCategories($product->getId())); | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, make this method private
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, please review: fae98c0 & 9a35b45