Skip to content

[Backport] fixed issue #19925 Close button overlapping in shipping address label whenever any user adding new shipping address in mobile view in checkout #20083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2019

Conversation

GovindaSharma
Copy link
Contributor

Original Pull Request

#19926

Description (*)

Close button overlapping in shipping address label whenever any user adding new shipping address in mobile view in checkout

Fixed Issues (if relevant)

  1. magento/magento2#<19925>: Close button overlapping in shipping address label whenever any user adding new shipping address in mobile view in checkout

Manual testing scenarios (*)

Note : testing should be in tab view or mobile view
Step 1: Go to frontend
Step 2: login as customer
Step 3: now add any product to cart and go to checkout
Step 4: in shipping address steps, you will see an saved address
Step 5: now click on add new address button or edit any saved address, then popup will open
(Now see actual result screenshot)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

cedarvinda and others added 2 commits January 5, 2019 06:21
Close button overlapping in shipping address label whenever any user adding new shipping address in mobile view in checkout
@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nuzil
Copy link
Contributor

nuzil commented Jan 5, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @nuzil. Thank you for your request. I'm working on Magento instance for you

@nuzil nuzil self-requested a review January 5, 2019 10:04
@nuzil nuzil self-assigned this Jan 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, here is your new Magento instance.
Admin access: https://pr-20083.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 5, 2019
@magento-engcom-team magento-engcom-team merged commit 8ecf64f into magento:2.2-develop Jan 10, 2019
@ghost
Copy link

ghost commented Jan 10, 2019

Hi @GovindaSharma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 10, 2019
…n shipping address label whenever any user adding new shipping address in mobile view in checkout #20083
@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants