-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Backport] MAGETWO-61422 Respect Category Top Navigation Max Depth setting #22235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The setting `Stores > Configuration > Catalog > Catalog > Category Top Navigation > Maximal Depth` was actually never being used to limit the topmenu. Now the setting will be used as a condition for the category collection when it is fetched.
Hi @torhoehn. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @orlangur, thank you for the review. |
✔️ QA passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the backport @torhoehn ! However, the pull request contains several backward incompatible and not suitable for patch upgrade changes (introduced public functions and constructor parameters)
Considering the above, wouldn't backport this change to 2.2-develop branch. Please let me know what you think
cc @orlangur
* | ||
* @return $this | ||
*/ | ||
public function addNavigationMaxDepthFilter() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding public methods to API classes in patch releases is prrrohibited by our backward compatibility policy
@torhoehn , I am closing this PR now due to inactivity. |
Hi @torhoehn, thank you for your contribution! |
Original Pull Request
#12640
Description
The setting
Stores > Configuration > Catalog > Catalog > Category Top Navigation > Maximal Depth
was actually never being used to limit the top menu maximum depth.Now the setting will be used as a condition for the category collection when it is fetched.
Fixed Issues
Manual testing scenarios
Contribution checklist