Skip to content

[Backport] MAGETWO-61422 Respect Category Top Navigation Max Depth setting #22235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[Backport] MAGETWO-61422 Respect Category Top Navigation Max Depth setting #22235

wants to merge 6 commits into from

Conversation

torhoehn
Copy link
Contributor

@torhoehn torhoehn commented Apr 9, 2019

Original Pull Request

#12640

Description

The setting Stores > Configuration > Catalog > Catalog > Category Top Navigation > Maximal Depth was actually never being used to limit the top menu maximum depth.

Now the setting will be used as a condition for the category collection when it is fetched.

Fixed Issues

  1. Category Top Navigation / Maximal Depth configuration not working #7543: Category Top Navigation / Maximal Depth configuration not working

Manual testing scenarios

  1. Change the setting in the backend
  2. Refresh the invalidated cache
  3. See that the setting actually is being used

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

arnoudhgz and others added 3 commits April 9, 2019 07:43
The setting `Stores > Configuration > Catalog > Catalog > Category Top Navigation > Maximal Depth` was actually never being used to limit the topmenu.

Now the setting will be used as a condition for the category collection when it is fetched.
@m2-assistant
Copy link

m2-assistant bot commented Apr 9, 2019

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned orlangur Apr 9, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4716 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the backport @torhoehn ! However, the pull request contains several backward incompatible and not suitable for patch upgrade changes (introduced public functions and constructor parameters)

Considering the above, wouldn't backport this change to 2.2-develop branch. Please let me know what you think

cc @orlangur

*
* @return $this
*/
public function addNavigationMaxDepthFilter()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding public methods to API classes in patch releases is prrrohibited by our backward compatibility policy

@sidolov
Copy link
Contributor

sidolov commented May 17, 2019

@torhoehn , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this May 17, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 17, 2019

Hi @torhoehn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@torhoehn torhoehn deleted the 2.2-develop-PR-port-12640 branch May 17, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants