Fix removing query string from url after redirect #25603

arendarenko · 2019-11-14T13:16:23Z

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

add ability to save query param from request during redirect to target path

update unit test

m2-assistant · 2019-11-14T13:16:26Z

Hi @arendarenko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

sdzhepa · 2019-11-14T19:21:47Z

Hello there
FYI: @arendarenko @ihor-sviziev @kokoc @akaplya @VladimirZaets

Previously fix related to this issue has been reverted by internal Magento team.
More details #18717 (comment)
IMO this PR could require additional architect review/approve

ihor-sviziev · 2019-11-15T06:02:08Z

Moved to "on hold", waiting for discussion with Architects

dev/tests/integration/testsuite/Magento/UrlRewrite/_files/url_rewrite.php

dev/tests/integration/testsuite/Magento/UrlRewrite/Controller/UrlRewriteTest.php

update fixture update integration test

magento-engcom-team · 2019-11-20T00:58:33Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6303 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

ihor-sviziev · 2019-11-20T04:55:11Z

Hi @lbajsarowicz,
From my perspective we need to approve it also, but we have some complains from Architects against it. Now I’m discussing this PR in Slack with @akaplya, hope we’ll decide to accept it.

ihor-sviziev · 2019-12-03T19:54:27Z

I double checked this PR after discussion with @akaplya (details here #18717 (comment)) - changes looks good.

Also I covered cases when target URL is external URL (not magento) with integration test, in this case GET params that came to magento should not be added to redirect URL.

Now this solution should works fine. Let's wait once all tests will be passing and then I'll approve this PR.

Cover with integration tests cases with external URLs as target path

ihor-sviziev · 2019-12-17T04:11:06Z

Hi @Zyles,
Could you add steps to reproduce, so we’ll be able to double check it?

Zyles · 2019-12-17T11:48:33Z

Hi @Zyles,
Could you add steps to reproduce, so we’ll be able to double check it?

Magento 2.3.3
Nginx
Letsencrypt SSL

Nginx config:

upstream fastcgi_backend {
    server   unix:/run/php/php7.3-fpm.sock;
}

server {
    listen 80;
    listen [::]:80;
    server_name store.example.com;
    return 301 https://store.example.com$request_uri;
}

server {

    listen [::]:443 ssl http2 ipv6only=on;
    listen 443 ssl http2;

    ssl on;
    ssl_ciphers EECDH+CHACHA20:EECDH+AES128:RSA+AES128:EECDH+AES256:RSA+AES256:EECDH+3DES:RSA+3DES:!MD5;
    ssl_certificate /etc/letsencrypt/live/example.com/fullchain.pem;
    ssl_certificate_key /etc/letsencrypt/live/example.com/privkey.pem;

    ssl_session_timeout 1d;
    ssl_session_cache shared:SSL:50m;
    ssl_session_tickets off;
    ssl_protocols TLSv1 TLSv1.1 TLSv1.2;
    ssl_prefer_server_ciphers on;
    ssl_stapling on;
    ssl_stapling_verify on;

    server_name store.example.com;
    set $MAGE_ROOT /home/http/example.com;
    set $MAGE_DEBUG_SHOW_ARGS 1;

    root $MAGE_ROOT/pub;

    index index.php;
    autoindex off;
    charset UTF-8;
    error_page 404 403 = /errors/404.php;

# PHP entry point for setup application
location ~* ^/setup($|/) {
    root $MAGE_ROOT;
    location ~ ^/setup/index.php {
        fastcgi_pass   fastcgi_backend;

        fastcgi_param  PHP_FLAG  "session.auto_start=off \n suhosin.session.cryptua=off";
	    fastcgi_param  PHP_VALUE "memory_limit=2G \n max_execution_time=600";
        fastcgi_read_timeout 600s;
        fastcgi_connect_timeout 600s;

        fastcgi_index  index.php;
        fastcgi_param  SCRIPT_FILENAME  $document_root$fastcgi_script_name;
        include        fastcgi_params;
    }

    location ~ ^/setup/(?!pub/). {
        deny all;
    }

    location ~ ^/setup/pub/ {
        add_header X-Frame-Options "SAMEORIGIN";
    }
}

# PHP entry point for update application
location ~* ^/update($|/) {
    root $MAGE_ROOT;

    location ~ ^/update/index.php {
        fastcgi_split_path_info ^(/update/index.php)(/.+)$;
        fastcgi_pass   fastcgi_backend;
        fastcgi_index  index.php;
        fastcgi_param  SCRIPT_FILENAME  $document_root$fastcgi_script_name;
        fastcgi_param  PATH_INFO        $fastcgi_path_info;
        include        fastcgi_params;
    }

    # Deny everything but index.php
    location ~ ^/update/(?!pub/). {
        deny all;
    }

    location ~ ^/update/pub/ {
        add_header X-Frame-Options "SAMEORIGIN";
    }
}

location / {
    try_files $uri $uri/ /index.php$is_args$args;
}

location /db/ {
    try_files $uri $uri/ /index.php$is_args$args;
}


location /pub/ {
    location ~ ^/pub/media/(downloadable|customer|import|theme_customization/.*\.xml) {
        deny all;
    }
    alias $MAGE_ROOT/pub/;
    add_header X-Frame-Options "SAMEORIGIN";
}

location /static/ {
    # Uncomment the following line in production mode
    # expires max;

    # Remove signature of the static files that is used to overcome the browser cache
    location ~ ^/static/version {
        rewrite ^/static/(version\d*/)?(.*)$ /static/$2 last;
    }

    location ~* \.(ico|jpg|jpeg|png|gif|svg|js|css|swf|eot|ttf|otf|woff|woff2)$ {
        add_header Cache-Control "public";
        add_header X-Frame-Options "SAMEORIGIN";
        expires +1y;

        if (!-f $request_filename) {
            rewrite ^/static/?(.*)$ /static.php?resource=$1 last;
        }
    }
    location ~* \.(zip|gz|gzip|bz2|csv|xml)$ {
        add_header Cache-Control "no-store";
        add_header X-Frame-Options "SAMEORIGIN";
        expires    off;

        if (!-f $request_filename) {
           rewrite ^/static/?(.*)$ /static.php?resource=$1 last;
        }
    }
    if (!-f $request_filename) {
        rewrite ^/static/?(.*)$ /static.php?resource=$1 last;
    }
    add_header X-Frame-Options "SAMEORIGIN";
}

location /media/ {
    try_files $uri $uri/ /get.php$is_args$args;

    location ~ ^/media/theme_customization/.*\.xml {
        deny all;
    }

    location ~* \.(ico|jpg|jpeg|png|gif|svg|js|css|swf|eot|ttf|otf|woff|woff2)$ {
        add_header Cache-Control "public";
        add_header X-Frame-Options "SAMEORIGIN";
        expires +1y;
        try_files $uri $uri/ /get.php$is_args$args;
    }
    location ~* \.(zip|gz|gzip|bz2|csv|xml)$ {
        add_header Cache-Control "no-store";
        add_header X-Frame-Options "SAMEORIGIN";
        expires    off;
        try_files $uri $uri/ /get.php$is_args$args;
    }
    add_header X-Frame-Options "SAMEORIGIN";
}

location /media/customer/ {
    deny all;
}

location /media/downloadable/ {
    deny all;
}

location /media/import/ {
    deny all;
}

# PHP entry point for main application
location ~ (index|get|static|errors/report|errors/404|errors/503|health_check|elastic)\.php$ {
    try_files $uri =404;
    fastcgi_pass   fastcgi_backend;
    fastcgi_buffers 1024 4k;

    fastcgi_param  PHP_FLAG  "session.auto_start=off \n suhosin.session.cryptua=off";
    #fastcgi_param  PHP_VALUE "memory_limit=768M \n max_execution_time=18000";
    fastcgi_param  PHP_VALUE "memory_limit=2G \n max_execution_time=600";
    fastcgi_read_timeout 600s;
    fastcgi_connect_timeout 600s;

    fastcgi_index  index.php;
    fastcgi_param  SCRIPT_FILENAME  $document_root$fastcgi_script_name;
    include        fastcgi_params;
}

gzip on;
gzip_disable "msie6";

gzip_comp_level 6;
gzip_min_length 1100;
gzip_buffers 16 8k;
gzip_proxied any;
gzip_types
    text/plain
    text/css
    text/js
    text/xml
    text/javascript
    application/javascript
    application/x-javascript
    application/json
    application/xml
    application/xml+rss
    image/svg+xml;
gzip_vary on;

# Banned locations (only reached if the earlier PHP entry point regexes don't match)
location ~* (\.php$|\.htaccess$|\.git) {
    deny all;
}

# Deny access to sensitive files
location /.user.ini {
    deny all;
}


}

ihor-sviziev · 2019-12-17T13:21:32Z

@magento give me test instance

magento-engcom-team · 2019-12-17T13:21:33Z

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento instance for you

ihor-sviziev · 2019-12-17T13:32:00Z

@Zyles ok, you provieded your environment configuration, but not steps to reproduce.

Actually I tried it on my own environment - everything works fine.
Unfortunately spinning up test instance doens't work somehow right now, so I can't give you test instance for checking it.

Please add more details, which URL rewrite do you have in the magento, which request you're doing, what are expected and actual result?

Also would be great in order to prevent any caching issues to send request via curl -I command, for instance curl -I http://example.com/my-category/?p=2

sdzhepa · 2019-12-17T15:13:31Z

@magento give me test instance

magento-engcom-team · 2019-12-17T15:13:37Z

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-12-17T15:14:29Z

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-25603.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Zyles · 2019-12-17T15:31:59Z

@Zyles ok, you provieded your environment configuration, but not steps to reproduce.

Actually I tried it on my own environment - everything works fine.
Unfortunately spinning up test instance doens't work somehow right now, so I can't give you test instance for checking it.

Please add more details, which URL rewrite do you have in the magento, which request you're doing, what are expected and actual result?

Also would be great in order to prevent any caching issues to send request via curl -I command, for instance curl -I http://example.com/my-category/?p=2

Go to a category.

Click paginate to page 2.

301 redirect to page 1.

/category/?p=2 -> /category/

Or type in the URL manually.

Zyles · 2019-12-17T15:36:48Z

$ curl -I https://store.magento/category/?p=2
HTTP/2 301
server: nginx
date: Tue, 17 Dec 2019 15:35:16 GMT
content-type: text/html; charset=UTF-8
location: https://store.magento/category/
set-cookie: PHPSESSID=uhtn3l6bb2t597g07do0424c09; expires=Fri, 17-Jan-2020 01:35:15 GMT; Max-Age=2628000; path=/; domain=store.magento; secure; HttpOnly
pragma: no-cache
cache-control: max-age=0, must-revalidate, no-cache, no-store
expires: Mon, 17 Dec 2018 15:35:15 GMT
strict-transport-security: max-age=31536000
content-security-policy: upgrade-insecure-requests;
x-content-type-options: nosniff
x-xss-protection: 1; mode=block
x-frame-options: SAMEORIGIN

Zyles · 2019-12-17T15:41:02Z

With SEO settings category suffix blank. No "/".

Creates duplicate content:

$ curl -I https://store.magento/category/?p=2
HTTP/2 200
server: nginx
date: Tue, 17 Dec 2019 15:38:11 GMT
content-type: text/html; charset=UTF-8
content-length: 363506
vary: Accept-Encoding
set-cookie: PHPSESSID=177nksbcr7e1jqf80ni3js7fkh; expires=Fri, 17-Jan-2020 01:38:11 GMT; Max-Age=2628000; path=/; domain=store.magento; secure; HttpOnly
pragma: no-cache
cache-control: max-age=0, must-revalidate, no-cache, no-store
expires: Mon, 17 Dec 2018 15:37:40 GMT
strict-transport-security: max-age=31536000
content-security-policy: upgrade-insecure-requests;
x-content-type-options: nosniff
x-xss-protection: 1; mode=block
x-frame-options: SAMEORIGIN

$ curl -I https://store.magento/category?p=2
HTTP/2 200
server: nginx
date: Tue, 17 Dec 2019 15:39:23 GMT
content-type: text/html; charset=UTF-8
content-length: 364548
vary: Accept-Encoding
pragma: no-cache
cache-control: max-age=0, must-revalidate, no-cache, no-store
expires: Mon, 17 Dec 2018 15:39:23 GMT
strict-transport-security: max-age=31536000
content-security-policy: upgrade-insecure-requests;
x-content-type-options: nosniff
x-xss-protection: 1; mode=block
x-frame-options: SAMEORIGIN

/category/?p=2 is not the same as /category?p=2

https://searchfacts.com/url-trailing-slash/

ihor-sviziev · 2019-12-17T15:45:36Z

Thx, will double check it little bit later, but definitely this is not expected result

…

On Tue, 17 Dec 2019 at 17:41, Zyles ***@***.***> wrote: With SEO settings category suffix blank. No "/". Creates duplicate content: $ curl -I https://store.magento/category/?p=2 HTTP/2 <https://store.magento/category/?p=2HTTP/2> 200 server: nginx date: Tue, 17 Dec 2019 15:38:11 GMT content-type: text/html; charset=UTF-8 content-length: 363506 vary: Accept-Encoding set-cookie: PHPSESSID=177nksbcr7e1jqf80ni3js7fkh; expires=Fri, 17-Jan-2020 01:38:11 GMT; Max-Age=2628000; path=/; domain=store.magento; secure; HttpOnly pragma: no-cache cache-control: max-age=0, must-revalidate, no-cache, no-store expires: Mon, 17 Dec 2018 15:37:40 GMT strict-transport-security: max-age=31536000 content-security-policy: upgrade-insecure-requests; x-content-type-options: nosniff x-xss-protection: 1; mode=block x-frame-options: SAMEORIGIN $ curl -I https://store.magento/category?p=2 HTTP/2 <https://store.magento/category?p=2HTTP/2> 200 server: nginx date: Tue, 17 Dec 2019 15:39:23 GMT content-type: text/html; charset=UTF-8 content-length: 364548 vary: Accept-Encoding pragma: no-cache cache-control: max-age=0, must-revalidate, no-cache, no-store expires: Mon, 17 Dec 2018 15:39:23 GMT strict-transport-security: max-age=31536000 content-security-policy: upgrade-insecure-requests; x-content-type-options: nosniff x-xss-protection: 1; mode=block x-frame-options: SAMEORIGIN /category/?p=2 is not the same as /category?p=2 https://searchfacts.com/url-trailing-slash/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25603?email_source=notifications&email_token=AAOJOUPDVQYTZH5GBNXBGYLQZDXJBA5CNFSM4JNLLX2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHCZHAQ#issuecomment-566596482>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOJOUNARWNS36XGDE34QCDQZDXJBANCNFSM4JNLLX2A> .

ihor-sviziev · 2019-12-17T16:37:39Z

@Zyles i just checked on test instance and wasn’t able to reproduce it, so I think it’s web server configuration issue.

https://pr-25603.instances.magento-community.engineering/category-1/?p=2

Just checked your nginx configuration and found following line:

    try_files $uri $uri/ /index.php$is_args$args;

I believe the / near the $url/ causing this issue.

Zyles · 2019-12-17T17:03:14Z

try_files $uri $uri /index.php$is_args$args;

Same problem.

Zyles · 2019-12-17T17:07:46Z

Does this demo have the pull request patch installed?

Can you populate the demo with sample products?

Zyles · 2019-12-17T17:15:02Z

@magento-engcom-team give me 2.3.3 instance

magento-engcom-team · 2019-12-17T17:15:08Z

Hi @Zyles. Thank you for your request. I'm working on Magento 2.3.3 instance for you

magento-engcom-team · 2019-12-17T17:16:17Z

Hi @Zyles, here is your Magento instance.
Admin access: https://i-25603-2-3-3.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

Zyles · 2019-12-17T17:22:54Z

https://i-25603-2-3-3.instances.magento-community.engineering/category/?p=2

Is it possible to apply pull request on this instance?

ihor-sviziev · 2019-12-17T17:32:54Z

It is already contains changes from this PR

…

On Tue, 17 Dec 2019 at 19:22, Zyles ***@***.***> wrote: https://i-25603-2-3-3.instances.magento-community.engineering/category/?p=2 Is it possible to apply pull request on this instance? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25603?email_source=notifications&email_token=AAOJOUJK2ULIRE77GSKPRIDQZEDG7A5CNFSM4JNLLX2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHDJN6I#issuecomment-566662905>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOJOUKV7PC7JGNVK3F57DTQZEDG7ANCNFSM4JNLLX2A> .

ihor-sviziev · 2019-12-17T17:34:01Z

Ah, no. We can request changes for this PR + changes from 2.4-develop, or changes from 2.3.3

BTW I added small performance profile to following instance, so there enough products
So there is changes from this PR on top of 2.4-develop branch
https://pr-25603.instances.magento-community.engineering/category-2/

Zyles · 2019-12-17T23:35:53Z

Reproduced ERR_TOO_MANY_REDIRECTS on local fresh install 2.3.3 with patched file:

vendor/magento/module-url-rewrite/Controller/Router.php:
$target = $this->url->getUrl('', ['_direct' => $target, '_query' => $request->getParams()]);

Please try 2.3.3. We can't upgrade to 2.4-develop on live website.

ihor-sviziev · 2019-12-18T07:13:43Z

@Zyles

Reproduced ERR_TOO_MANY_REDIRECTS on local fresh install 2.3.3 with patched file:
vendor/magento/module-url-rewrite/Controller/Router.php:
$target = $this->url->getUrl('', ['_direct' => $target, '_query' => $request->getParams()]);
Please try 2.3.3. We can't upgrade to 2.4-develop on live website.

Yeah, I finally found it.
Only in Magento 2.3.3 were added changes that suppose to fix described issue, but after this release came - it caused another issues, so in 2.4-develop that changes were reverted. More info: #18717 (comment)

So in order to have correct fix for 2.3.3 - before you need to apply following commit fa468e7 (reverts changes that were added to 2.3.3) and only then apply changes from this PR.

So changes from this PR should works fine. Could you confirm that?

Zyles · 2019-12-18T14:19:48Z

Thank you, seems to work now.

m2-assistant · 2020-01-03T03:22:09Z

Hi @arendarenko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

arendarenko added 2 commits November 14, 2019 15:08

UrlRewrite module fixes

0693cc2

add ability to save query param from request during redirect to target path

UrlRewrite module fixes

19b7bda

update unit test

arendarenko added the Component: UrlRewrite label Nov 14, 2019

arendarenko requested a review from ihor-sviziev November 14, 2019 13:16

arendarenko requested a review from kokoc as a code owner November 14, 2019 13:16

magento-engcom-team added the Release Line: 2.3 label Nov 14, 2019

arendarenko force-pushed the fix-for-18717 branch from 9b62325 to 29c8dd7 Compare November 14, 2019 13:37

ihor-sviziev self-assigned this Nov 14, 2019

ghost added the Progress: on hold label Nov 15, 2019

ihor-sviziev reviewed Nov 15, 2019

View reviewed changes

dev/tests/integration/testsuite/Magento/UrlRewrite/_files/url_rewrite.php Show resolved Hide resolved

dev/tests/integration/testsuite/Magento/UrlRewrite/Controller/UrlRewriteTest.php Outdated Show resolved Hide resolved

arendarenko force-pushed the fix-for-18717 branch from 29c8dd7 to 907cb89 Compare November 15, 2019 10:36

UrlRewrite module fixes

f63475c

update fixture update integration test

arendarenko force-pushed the fix-for-18717 branch from 907cb89 to f63475c Compare November 15, 2019 11:16

lbajsarowicz approved these changes Nov 20, 2019

View reviewed changes

ghost assigned lbajsarowicz Nov 20, 2019

ghost added Progress: ready for testing and removed Progress: on hold labels Nov 20, 2019

ghost added Progress: on hold and removed Progress: ready for testing labels Nov 20, 2019

ihor-sviziev removed the Progress: on hold label Dec 3, 2019

magento#25603 Fix removing query string from url after redirect

b1a2a29

Cover with integration tests cases with external URLs as target path

ihor-sviziev force-pushed the fix-for-18717 branch from e9514f7 to b1a2a29 Compare December 4, 2019 07:29

ihor-sviziev approved these changes Dec 4, 2019

View reviewed changes

maaarghk mentioned this pull request Dec 19, 2019

UrlRewrite removes query string from url, if url has trailing slash #18717

Closed

Zyles mentioned this pull request Dec 27, 2019

More than one redirect with trailing slash in secure non-www url #26177

Closed

magento-engcom-team pushed a commit that referenced this pull request Jan 3, 2020

ENGCOM-6303: Fix removing query string from url after redirect #25603

1b08ad2

magento-engcom-team merged commit b1a2a29 into magento:2.4-develop Jan 3, 2020

sdzhepa mentioned this pull request May 9, 2022

tyutyu sdzhepa/magento2#5

Open

Fix removing query string from url after redirect #25603

Fix removing query string from url after redirect #25603

Uh oh!

Conversation

arendarenko commented Nov 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Nov 14, 2019

Uh oh!

sdzhepa commented Nov 14, 2019

Uh oh!

ihor-sviziev commented Nov 15, 2019

Uh oh!

Uh oh!

Uh oh!

magento-engcom-team commented Nov 20, 2019

Uh oh!

ihor-sviziev commented Nov 20, 2019

Uh oh!

ihor-sviziev commented Dec 3, 2019

Uh oh!

ihor-sviziev commented Dec 17, 2019

Uh oh!

Zyles commented Dec 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ihor-sviziev commented Dec 17, 2019

Uh oh!

magento-engcom-team commented Dec 17, 2019

Uh oh!

ihor-sviziev commented Dec 17, 2019

Uh oh!

sdzhepa commented Dec 17, 2019

Uh oh!

magento-engcom-team commented Dec 17, 2019

Uh oh!

magento-engcom-team commented Dec 17, 2019

Uh oh!

Zyles commented Dec 17, 2019

Uh oh!

Zyles commented Dec 17, 2019

Uh oh!

Zyles commented Dec 17, 2019

Uh oh!

ihor-sviziev commented Dec 17, 2019 via email

Uh oh!

ihor-sviziev commented Dec 17, 2019

Uh oh!

Zyles commented Dec 17, 2019

Uh oh!

Zyles commented Dec 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zyles commented Dec 17, 2019

Uh oh!

magento-engcom-team commented Dec 17, 2019

Uh oh!

magento-engcom-team commented Dec 17, 2019

Uh oh!

Zyles commented Dec 17, 2019

Uh oh!

ihor-sviziev commented Dec 17, 2019 via email

Uh oh!

ihor-sviziev commented Dec 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zyles commented Dec 17, 2019

Uh oh!

ihor-sviziev commented Dec 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zyles commented Dec 18, 2019

Uh oh!

m2-assistant bot commented Jan 3, 2020

Uh oh!

arendarenko commented Nov 14, 2019 •

edited

Loading

Zyles commented Dec 17, 2019 •

edited

Loading

Zyles commented Dec 17, 2019 •

edited

Loading

ihor-sviziev commented Dec 17, 2019 •

edited

Loading

ihor-sviziev commented Dec 18, 2019 •

edited

Loading