Skip to content

[TEST] This PR is for testing only, DO NOT MERGE. #26594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

nwmagento
Copy link

@nwmagento nwmagento commented Jan 30, 2020

This PR is for testing githubapp functionality do not merge.

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. [TEST] Do not process #27441

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

This modification is for testing a githubapp only, do not merge.
[TEST] Updated Readme with a space for testing.
@m2-assistant
Copy link

m2-assistant bot commented Jan 30, 2020

Hi @nwmagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@nwmagento
Copy link
Author

Hey MDS give me test instance

@magento-deployment-service
Copy link

Hi @nwmagento Here is your new Magento Instance: https://undefined
Admin access: https://undefined/undefined
Login: undefined , Password: undefined

@nwmagento
Copy link
Author

Hey MDS give me test instance

@magento-deployment-service
Copy link

Hi @nwmagento Here is your new Magento Instance: https://undefined
Admin access: https://undefined/undefined
Login: undefined , Password: undefined

@nwmagento
Copy link
Author

Hey MDS give me test instance

@magento-deployment-service
Copy link

Hi @nwmagento Here is your new Magento Instance: https://undefined
Admin access: https://undefined/undefined
Login: undefined , Password: undefined

@nwmagento
Copy link
Author

Hey MDS give me test instance

@magento-deployment-service
Copy link

Hi @nwmagento Here is your new Magento Instance: https://undefined
Admin access: https://undefined/undefined
Login: undefined , Password: undefined

@nwmagento
Copy link
Author

Hey MDS give me test instance

@magento-deployment-service
Copy link

Hi @nwmagento Here is your new Magento Instance: https://pr-26594.magento-testing-service.engineering
Admin access: https://pr-26594.magento-testing-service.engineering/undefined
Login: undefined , Password: undefined

@nwmagento
Copy link
Author

Hey MDS give me test instance

@magento-deployment-service
Copy link

Hi @nwmagento Here is your new Magento Instance: https://pr-26594.magento-testing-service.engineering
Admin access: https://pr-26594.magento-testing-service.engineering/admin_90e6
Login: 6f551924 , Password: 967e9a263c0c

@ihor-sviziev ihor-sviziev self-assigned this Feb 10, 2020
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nwmagento
Still you need this PR, or we can close it?

@nwmagento
Copy link
Author

I am done with it for now, I might need another in the near future. I will close it, and reopen/open a new one as needed.

@nwmagento nwmagento closed this Feb 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 10, 2020

Hi @nwmagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@nwmagento nwmagento reopened this Feb 18, 2020
@ghost ghost unassigned ihor-sviziev Feb 18, 2020
@nwmagento
Copy link
Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @nwmagento. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @nwmagento, here is your new Magento instance.
Admin access: https://pr-26594.instances.magento-community.engineering/admin_c89f
Login: b2434ee7 Password: d244ba13075b
Instance will be terminated in up to 3 hours.

@nwmagento
Copy link
Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @nwmagento. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @nwmagento, here is your new Magento instance.
Admin access: https://pr-26594.instances.magento-community.engineering/admin_9a9e
Login: 89c998fe Password: f32828e397a6
Instance will be terminated in up to 3 hours.

@nwmagento
Copy link
Author

@magento give me test instance

@magento-deployment-service
Copy link

Hi @nwmagento Here is your new Magento Instance: https://pr-26594.magento-testing-service.engineering
Admin access: https://pr-26594.magento-testing-service.engineering/undefined
Login: undefined , Password: undefined

@magento-engcom-team
Copy link
Contributor

Hi @nwmagento. Thank you for your request. I'm working on Magento instance for you

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @nwmagento. Thank you for your request. I'm working on Magento instance for you

@magento-deployment-service
Copy link

Hi @nwmagento Here is your new Magento Instance: https://pr-26594.magento-testing-service.engineering
Admin access: https://pr-26594.magento-testing-service.engineering/undefined
Login: undefined , Password: undefined

@magento-engcom-team
Copy link
Contributor

Hi @nwmagento, here is your new Magento instance.
Admin access: https://pr-26594.instances.magento-community.engineering/admin_5da8
Login: d73cdefd Password: cce13bc904ac
Instance will be terminated in up to 3 hours.

@ihor-sviziev
Copy link
Contributor

@nwmagento
Is it possible to fix login selection issue in this message? Right now double click on the username also selects space after it, but with password everything ok
image

@nwmagento
Copy link
Author

@ihor-sviziev yes, I will make sure that in the new version I'm working on, that will be addressed.

@nwmagento
Copy link
Author

@test-magento give me test instance

@magento-deployment-service
Copy link

Hi @nwmagento Here is your new Magento Instance: https://pr-26594.magento-testing-service.engineering
Admin access: https://pr-26594.magento-testing-service.engineering/undefined
Login: undefined , Password: undefined

@nwmagento
Copy link
Author

nwmagento commented Feb 19, 2020

testing: Instance: https://pr-26594.magento-testing-service.engineering
Admin access: https://pr-26594.magento-testing-service.engineering/admin_6d45
Login: 2110bacd, Password: 9a9f7c3972ed

@magento-deployment-service
Copy link

Hi @nwmagento Here is your new Magento Instance: https://pr-26594.magento-testing-service.engineering
Admin access: https://pr-26594.magento-testing-service.engineering/admin_6d45
Login: 2110bacd , Password: 9a9f7c3972ed

@nwmagento
Copy link
Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @nwmagento. Thank you for your request. I'm working on Magento instance for you

@magento-deployment-service
Copy link

Hi @nwmagento Here is your new Magento Instance: https://pr-26594.magento-testing-service.engineering
Admin access: https://pr-26594.magento-testing-service.engineering/admin_cd98
Login: f181883d, Password: f231ab04ce3d

@magento-engcom-team
Copy link
Contributor

Hi @nwmagento, here is your new Magento instance.
Admin access: https://pr-26594.instances.magento-community.engineering/admin_7cf4
Login: 686d4e17 Password: d105c8164e7e
Instance will be terminated in up to 3 hours.

@nwmagento
Copy link
Author

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @nwmagento. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-deployment-service
Copy link

Hi @nwmagento Here is your new Magento Instance: https://i-26594-2-4-develop.magento-testing-service.engineering
Admin access: https://i-26594-2-4-develop.magento-testing-service.engineering/admin_8401
Login: b4691fcb, Password: 99bf27d10dbd

@magento-engcom-team
Copy link
Contributor

Hi @nwmagento, here is your Magento instance.
Admin access: https://i-26594-2-4-develop.instances.magento-community.engineering/admin_2d4e
Login: 906b6bda Password: c40f7b35625a
Instance will be terminated in up to 3 hours.

@nwmagento
Copy link
Author

@ihor-sviziev Added the fix for the space. Tested, and it is deployed now. the previous magento-engcom-team's deploying of a test instance has been disabled.

@nwmagento nwmagento closed this Feb 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 19, 2020

Hi @nwmagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ihor-sviziev
Copy link
Contributor

@nwmagento thank you!

However I found really interesting case:
image

#26939 (comment)

@nwmagento
Copy link
Author

@ihor-sviziev I made a change, so the magento-deployment-service bot will now ignore messages from other github bots.
Is there ever a case where a user will request both a test instance, and a 2.4-develop instance in the same comment?

@ihor-sviziev
Copy link
Contributor

@nwmagento I think if needed it could be just two comments, it’s not a big deal

@m2-assistant
Copy link

m2-assistant bot commented Mar 25, 2020

Hi @nwmagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants