Skip to content

ObjectManager cleanup - Remove usage from AdminNotification module #26939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 12, 2020
Merged

ObjectManager cleanup - Remove usage from AdminNotification module #26939

merged 6 commits into from
Mar 12, 2020

Conversation

ihor-sviziev
Copy link
Contributor

Description (*)

This PR cleans up object manager usage and marks optional arguments as not optional in non API classes.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 20, 2020

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-deployment-service
Copy link

Hi @m2-assistant[bot] Here is your new Magento Instance: https://undefined
Admin access: https://undefined/undefined
Login: undefined, Password: undefined

@ihor-sviziev ihor-sviziev mentioned this pull request Feb 20, 2020
Closed
4 tasks
@ihor-sviziev ihor-sviziev force-pushed the cleanup-objectmanager-fallback branch from 0a36b13 to dfda317 Compare February 20, 2020 08:20
@ihor-sviziev ihor-sviziev force-pushed the cleanup-objectmanager-fallback branch from dfda317 to d359cdf Compare February 20, 2020 08:21
lbajsarowicz
lbajsarowicz previously approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihor-sviziev Please fix static tests.
There are minor comments, generally speaking 👍

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6942 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ghost ghost dismissed lbajsarowicz’s stale review February 20, 2020 13:00

Pull Request state was updated. Re-review required.

@ihor-sviziev
Copy link
Contributor Author

@lbajsarowicz could you request the changes in order not to move them to test?

lbajsarowicz
lbajsarowicz suggested changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving at "Request changes" for styling the PHP files.

@ghost ghost assigned ihor-sviziev Feb 26, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6942 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ihor-sviziev ihor-sviziev removed their assignment Feb 26, 2020
@engcom-Delta engcom-Delta self-assigned this Feb 27, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Kilo engcom-Kilo self-assigned this Feb 27, 2020
Nazar65
Nazar65 suggested changes Feb 28, 2020
View reviewed changes
Copy link
Member

@Nazar65 Nazar65 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @engcom-Kilo it would be great if you will squash commits into one.

@Bartlomiejsz Bartlomiejsz mentioned this pull request Mar 3, 2020
Closed
4 tasks
@engcom-Kilo engcom-Kilo force-pushed the cleanup-objectmanager-fallback branch from 84d80f4 to 91e3afb Compare March 3, 2020 11:53
@engcom-Kilo engcom-Kilo force-pushed the cleanup-objectmanager-fallback branch from 91e3afb to 2598994 Compare March 3, 2020 11:59
@engcom-Kilo engcom-Kilo requested a review from Nazar65 March 3, 2020 12:41
Nazar65
Nazar65 suggested changes Mar 3, 2020
View reviewed changes
app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/MassMarkAsRead.php Outdated
* @return void
* @inheritdoc
*
* @return \Magento\Framework\App\ResponseInterface|\Magento\Framework\Controller\ResultInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@return is not required if there already @inheritdoc

app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/MassRemove.php Outdated
* @return void
* @inheritdoc
*
* @return \Magento\Framework\App\ResponseInterface|\Magento\Framework\Controller\ResultInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/Remove.php Outdated
* @return void
* @inheritdoc
*
* @return \Magento\Framework\App\ResponseInterface|\Magento\Framework\Controller\ResultInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@engcom-Kilo
magento2/pull/26939: Fixed static test.
57af3d7
@engcom-Kilo
Merge remote-tracking branch 'ihor-sviziev/cleanup-objectmanager-fall…
6ec7be9 
…back' into cleanup-objectmanager-fallback

# Conflicts:
#	app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/MarkAsRead.php
#	app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/MassMarkAsRead.php
#	app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/MassRemove.php
#	app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/Remove.php
@engcom-Kilo
magento2/pull/26939: Fixed static test.
b7c1d04
@engcom-Kilo engcom-Kilo requested a review from Nazar65 March 4, 2020 11:23
@slavvka slavvka added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Mar 4, 2020
magento-engcom-team pushed a commit that referenced this pull request Mar 12, 2020
@slavvka
ENGCOM-6942: ObjectManager cleanup - Remove usage from AdminNotificat…
51755fd 
…ion module #26939
@magento-engcom-team magento-engcom-team merged commit 480f8ab into magento:2.4-develop Mar 12, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 12, 2020

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@Nazar65 Nazar65 Nazar65 approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Delta engcom-Delta

@engcom-Kilo engcom-Kilo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Cleanup Component: AdminNotification Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ihor-sviziev @magento-engcom-team @engcom-Delta @lbajsarowicz @Nazar65 @slavvka @engcom-Kilo