Skip to content

Fixed Null order in Print All Shipments guest page #28864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fixed Null order in Print All Shipments guest page #28864

wants to merge 2 commits into from

Conversation

themystery404
Copy link

Description (*)

Fixed getting PHP error during printing All Shipments in guest order page

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Null order in Print All Shipments guest page (Magento\Sales\Block\Order\PrintShipment.php) #28861 Null order in Print All Shipments guest page (Magento\Sales\Block\Order\PrintShipment.php)

Manual testing scenarios (*)

  1. Place an order as guest user and create shipment for it.
  2. Go to http://example.com/sales/guest/shipment/order_id/123456/
  3. Change tab on "Order Shipment".
  4. Click on "Print All Shipment" link

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 24, 2020

Hi @themystery404. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@sdzhepa
Copy link
Contributor

sdzhepa commented Jun 25, 2020

Closed due to #28861 (comment)

@sdzhepa sdzhepa closed this Jun 25, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 25, 2020

Hi @themystery404, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null order in Print All Shipments guest page (Magento\Sales\Block\Order\PrintShipment.php)
3 participants