Switching between Media Gallery bookmarks does not change the selected folder #29411

joweecaquicla · 2020-08-05T17:22:44Z

Description (*)

This PR will implement the fix to change the selected folder when switching views in Media Gallery.

Related Pull Requests

N/A

Fixed Issues (if relevant)

Fixes Switching between Views does not change the selected folder. [Media Gallery] adobe-stock-integration#1523

Manual testing scenarios (*)

Apart from the mentioned steps please check directory navigation/operations in general

Go Content - Pages click Add New Page
Expand Content click Show / Hide Editor, Insert Image...
Create a main folder named folder for example and select it
Click on Default View dropdown
Click Save View As..., and click Save all changes ( ➡️ )
now you have a New View with the selected folder
Close the Media Gallery and go to Catalog - Categories
Expand Content and click Select from Gallery
folder is selected
Try to switch between New View and Default View
The folder selected for that view must be highlighted/selected,
i.e.: If New View is selected, folder should be selected,
Catalog/category folder is selected if the Default view is selected

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…23-switching-between-views-does-not-change-the-selected-folder

…t change the selected folder. [Media Gallery] - modified function to select folder when switching view

…t change the selected folder. [Media Gallery] - modified functions

m2-assistant · 2020-08-05T17:22:47Z

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

joweecaquicla · 2020-08-05T17:23:21Z

@magento run all tests

sivaschenko

Thanks for the PR @joweecaquicla ! Please see my comments

Can you please cover this case with an MFTF test

Also please check the static tests https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/29411/a3de7a89d23fb2784c34d24facce7d29/Statics/allure-report-b2b/index.html#categories/0a4a9c930701952d758f01ac4e2bb450/6a07c842b5a5c7f8/

app/code/Magento/MediaGalleryUi/view/adminhtml/web/js/directory/directoryTree.js

sivaschenko · 2020-08-06T07:58:28Z

app/code/Magento/MediaGalleryUi/view/adminhtml/web/js/directory/directoryTree.js

@@ -281,8 +285,8 @@ define([
         * @param {String} currentFilterPath
         */
        isFiltersApplied: function (currentFilterPath) {
-            return !_.isUndefined(currentFilterPath) && currentFilterPath !== '' &&
-                currentFilterPath !== 'wysiwyg' && currentFilterPath !== 'catalog/category';
+            return !_.isUndefined(currentFilterPath) && currentFilterPath !== ''


I think catalog/category comparison should also be removed (cc @Nazar65 )

this comparisons needed to cover behavior with pres elected folders, for example when bookmark applied and we open media gallery from category, category folder should be presented only if the bookmarks not available

…23-switching-between-views-does-not-change-the-selected-folder

…t change the selected folder. [Media Gallery] - implement request change and mftf test

joweecaquicla · 2020-08-06T20:17:36Z

@magento run all tests

sivaschenko

Thanks for updates @joweecaquicla ! The implementation looks good! Can you please check the failed tests

…t change the selected folder. [Media Gallery] - fix failed static test

joweecaquicla · 2020-08-07T15:15:32Z

@magento run all tests

joweecaquicla · 2020-08-07T19:01:32Z

@magento run Database Compare, Functional Tests CE, Functional Tests EE

sivaschenko · 2020-08-13T16:23:21Z

@magento run all tests

…-not-change-the-selected-folder

sivaschenko · 2020-08-24T16:57:45Z

@magento run all tests

sivaschenko · 2020-08-24T19:12:18Z

@magento run Static Tests

sivaschenko · 2020-08-25T11:00:54Z

@magento run Static Tests

sivaschenko · 2020-08-25T12:27:29Z

@magento run Static Tests

…-not-change-the-selected-folder

sivaschenko · 2020-08-25T13:03:12Z

@magento run all tests

magento-engcom-team · 2020-08-25T13:05:21Z

Hi @sivaschenko, thank you for the review.
ENGCOM-8008 has been created to process this Pull Request

chalov-anton · 2020-08-26T09:41:55Z

✔️ QA Passed

The folder is selected and deselected correctly while switching Views

Manual testing scenario - https://studio.cucumber.io/projects/131313/test-plan/folders/1337102/scenarios/5060037

…ed folder. [Media Gallery] #29411

m2-assistant · 2020-08-27T08:11:57Z

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

joweecaquicla added 3 commits August 5, 2020 20:54

Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-15…

8020a01

…23-switching-between-views-does-not-change-the-selected-folder

magento/adobe-stock-integration#1523: Switching between Views does no…

8e1e390

…t change the selected folder. [Media Gallery] - modified function to select folder when switching view

magento/adobe-stock-integration#1523: Switching between Views does no…

ee2ab23

…t change the selected folder. [Media Gallery] - modified functions

joweecaquicla added the Project: ASI label Aug 5, 2020

ghost added the Progress: pending review label Aug 5, 2020

magento-engcom-team added Area: Frontend Component: MediaGalleryUi Release Line: 2.4 labels Aug 5, 2020

sivaschenko requested changes Aug 6, 2020

View reviewed changes

ghost assigned sivaschenko Aug 6, 2020

ghost added Progress: needs update and removed Progress: pending review labels Aug 6, 2020

joweecaquicla added 2 commits August 6, 2020 18:38

Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-15…

e94ffe6

…23-switching-between-views-does-not-change-the-selected-folder

Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-15…

3396cfd

…23-switching-between-views-does-not-change-the-selected-folder

joweecaquicla changed the title ~~1523: Switching between Views does not change the selected folder. [Media Gallery]~~ [WIP] 1523: Switching between Views does not change the selected folder. [Media Gallery] Aug 6, 2020

magento/adobe-stock-integration#1523: Switching between Views does no…

20dc815

…t change the selected folder. [Media Gallery] - implement request change and mftf test

joweecaquicla requested a review from sivaschenko August 6, 2020 20:17

joweecaquicla changed the title ~~[WIP] 1523: Switching between Views does not change the selected folder. [Media Gallery]~~ 1523: Switching between Views does not change the selected folder. [Media Gallery] Aug 6, 2020

sivaschenko requested changes Aug 7, 2020

View reviewed changes

magento/adobe-stock-integration#1523: Switching between Views does no…

58efb76

…t change the selected folder. [Media Gallery] - fix failed static test

sivaschenko added Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Aug 9, 2020

magento#29411: Directory Tree refactoring

60da76c

sivaschenko added 2 commits August 24, 2020 17:56

magento#29411: Fixed MFTF test

79c8386

Merge branch '2.4-develop' into ASI-1523-switching-between-views-does…

4a354da

…-not-change-the-selected-folder

Fixed static tests

ae61599

Fixed static tests

a68bbbd

Fixed static tests

e533396

sivaschenko approved these changes Aug 25, 2020

View reviewed changes

Merge branch '2.4-develop' into ASI-1523-switching-between-views-does…

218c017

…-not-change-the-selected-folder

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 25, 2020

chalov-anton self-assigned this Aug 26, 2020

ghost added Progress: testing in progress Progress: extended testing and removed Progress: ready for testing Progress: testing in progress labels Aug 26, 2020

chalov-anton added Progress: testing in progress QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed Progress: extended testing labels Aug 26, 2020

ghost added Progress: accept and removed Progress: testing in progress labels Aug 26, 2020

magento-engcom-team pushed a commit that referenced this pull request Aug 27, 2020

ENGCOM-8008: 1523: Switching between Views does not change the select…

0cd2e2f

…ed folder. [Media Gallery] #29411

magento-engcom-team merged commit 0d75669 into magento:2.4-develop Aug 27, 2020

sivaschenko changed the title ~~1523: Switching between Views does not change the selected folder. [Media Gallery]~~ Switching between Media Gallery bookmarks does not change the selected folder Sep 7, 2020

Switching between Media Gallery bookmarks does not change the selected folder #29411

Switching between Media Gallery bookmarks does not change the selected folder #29411

Uh oh!

Conversation

joweecaquicla commented Aug 5, 2020 • edited by sivaschenko Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Aug 5, 2020

Uh oh!

joweecaquicla commented Aug 5, 2020

Uh oh!

sivaschenko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sivaschenko Aug 6, 2020

Choose a reason for hiding this comment

Uh oh!

Nazar65 Aug 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joweecaquicla commented Aug 6, 2020

Uh oh!

sivaschenko left a comment

Choose a reason for hiding this comment

Uh oh!

joweecaquicla commented Aug 7, 2020

Uh oh!

joweecaquicla commented Aug 7, 2020

Uh oh!

sivaschenko commented Aug 13, 2020

Uh oh!

sivaschenko commented Aug 24, 2020

Uh oh!

sivaschenko commented Aug 24, 2020

Uh oh!

sivaschenko commented Aug 25, 2020

Uh oh!

sivaschenko commented Aug 25, 2020

Uh oh!

sivaschenko commented Aug 25, 2020

Uh oh!

magento-engcom-team commented Aug 25, 2020

Uh oh!

chalov-anton commented Aug 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m2-assistant bot commented Aug 27, 2020

Uh oh!

Uh oh!

joweecaquicla commented Aug 5, 2020 •

edited by sivaschenko

Loading

Nazar65 Aug 14, 2020 •

edited

Loading

chalov-anton commented Aug 26, 2020 •

edited

Loading