-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Switching between Media Gallery bookmarks does not change the selected folder #29411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
magento-engcom-team
merged 19 commits into
magento:2.4-develop
from
joweecaquicla:ASI-1523-switching-between-views-does-not-change-the-selected-folder
Aug 27, 2020
Merged
Changes from 7 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8020a01
Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-15…
8e1e390
magento/adobe-stock-integration#1523: Switching between Views does no…
ee2ab23
magento/adobe-stock-integration#1523: Switching between Views does no…
e94ffe6
Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-15…
3396cfd
Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-15…
20dc815
magento/adobe-stock-integration#1523: Switching between Views does no…
58efb76
magento/adobe-stock-integration#1523: Switching between Views does no…
60da76c
magento/magento2#29411: Directory Tree refactoring
sivaschenko a516ee5
magento/magento2#29411: Naming update
sivaschenko 0d0aa22
Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-15…
sivaschenko eb1f0bb
magento/magento2#29411: Updated requested directory selection behaviour
sivaschenko 36074a9
magento/magento2#29411: Formatting fixes
sivaschenko 9a69a6a
magento/magento2#29411: Fixed static tests
sivaschenko 79c8386
magento/magento2#29411: Fixed MFTF test
sivaschenko 4a354da
Merge branch '2.4-develop' into ASI-1523-switching-between-views-does…
sivaschenko ae61599
Fixed static tests
sivaschenko a68bbbd
Fixed static tests
sivaschenko e533396
Fixed static tests
sivaschenko 218c017
Merge branch '2.4-develop' into ASI-1523-switching-between-views-does…
sivaschenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
25 changes: 25 additions & 0 deletions
25
app/code/Magento/MediaGalleryUi/Test/Mftf/ActionGroup/AssertFolderIsChangedActionGroup.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
--> | ||
|
||
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | ||
<actionGroup name="AssertFolderIsChangedActionGroup"> | ||
<annotations> | ||
<description>Assert that folder is changed</description> | ||
</annotations> | ||
<arguments> | ||
<argument name="newSelectedFolder" type="string"/> | ||
<argument name="oldSelectedFolder" type="string" defaultValue="{{AdminMediaGalleryFolderData.name}}"/> | ||
</arguments> | ||
|
||
<assertNotEquals stepKey="assertNotEqual"> | ||
<actualResult type="string">{{newSelectedFolder}}</actualResult> | ||
<expectedResult type="string">{{oldSelectedFolder}}</expectedResult> | ||
</assertNotEquals> | ||
</actionGroup> | ||
</actionGroups> |
63 changes: 63 additions & 0 deletions
63
...code/Magento/MediaGalleryUi/Test/Mftf/Test/AdminMediaGallerySwitchingBetweenViewsTest.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
--> | ||
|
||
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd"> | ||
<test name="AdminMediaGallerySwitchingBetweenViewsTest"> | ||
<annotations> | ||
<features value="MediaGallery"/> | ||
<useCaseId value="https://github.com/magento/adobe-stock-integration/issues/1523"/> | ||
<title value="User switches between Views and checks if the folder is changed"/> | ||
<stories value="User switches between Views and checks if the folder is changed"/> | ||
<testCaseId value="https://studio.cucumber.io/projects/131313/test-plan/folders/1337102/scenarios/5060037"/> | ||
<description value="User switches between Views and checks if the folder is changed"/> | ||
<severity value="CRITICAL"/> | ||
<group value="media_gallery_ui"/> | ||
</annotations> | ||
<before> | ||
<createData entity="SimpleSubCategory" stepKey="category"/> | ||
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/> | ||
</before> | ||
<after> | ||
<actionGroup ref="ResetAdminDataGridToDefaultViewActionGroup" stepKey="resetAdminDataGridToDefaultView"/> | ||
<actionGroup ref="AdminEnhancedMediaGalleryDeleteGridViewActionGroup" stepKey="deleteView"> | ||
<argument name="viewToDelete" value="New View"/> | ||
</actionGroup> | ||
<actionGroup ref="AdminMediaGalleryFolderSelectActionGroup" stepKey="selectFolderForDelete"/> | ||
<actionGroup ref="AdminMediaGalleryFolderDeleteActionGroup" stepKey="deleteFolder"/> | ||
<actionGroup ref="AdminMediaGalleryAssertFolderDoesNotExistActionGroup" stepKey="assertFolderWasDeleted"/> | ||
<deleteData createDataKey="category" stepKey="deleteCategory"/> | ||
</after> | ||
<actionGroup ref="AdminOpenCreateNewCMSPageActionGroup" stepKey="openNewPage"/> | ||
<actionGroup ref="AdminOpenMediaGalleryFromPageNoEditorActionGroup" stepKey="openMediaGalleryForPage"/> | ||
<actionGroup ref="ClearFiltersAdminDataGridActionGroup" stepKey="clearFilters"/> | ||
<actionGroup ref="AdminMediaGalleryOpenNewFolderFormActionGroup" stepKey="openNewFolderForm"/> | ||
<actionGroup ref="AdminMediaGalleryCreateNewFolderActionGroup" stepKey="createNewFolder"/> | ||
<actionGroup ref="AdminMediaGalleryAssertFolderNameActionGroup" stepKey="assertNewFolderCreated"/> | ||
<waitForLoadingMaskToDisappear stepKey="waitForFolderContents"/> | ||
<actionGroup ref="AdminEnhancedMediaGallerySaveCustomViewActionGroup" stepKey="saveCustomView"> | ||
<argument name="viewName" value="New View"/> | ||
</actionGroup> | ||
<actionGroup ref="AdminOpenCategoryPageActionGroup" stepKey="openCategoryPage"/> | ||
<actionGroup ref="AdminCategoriesOpenCategoryActionGroup" stepKey="openCategory"> | ||
<argument name="category" value="$$category$$"/> | ||
</actionGroup> | ||
<actionGroup ref="AdminOpenMediaGalleryFromCategoryImageUploaderActionGroup" stepKey="openMediaGalleryFromImageUploader"/> | ||
<actionGroup ref="AdminEnhancedMediaGallerySelectCustomBookmarksViewActionGroup" stepKey="selectDefaultView"> | ||
<argument name="selectView" value="Default View"/> | ||
</actionGroup> | ||
<actionGroup ref="AssertFolderIsChangedActionGroup" stepKey="assertFolderIsChanged"> | ||
<argument name="newSelectedFolder" value="category" /> | ||
</actionGroup> | ||
<actionGroup ref="AdminEnhancedMediaGallerySelectCustomBookmarksViewActionGroup" stepKey="switchBackToNewView"> | ||
<argument name="selectView" value="New View"/> | ||
</actionGroup> | ||
<actionGroup ref="AdminEnhancedMediaGalleryAssertActiveFiltersActionGroup" stepKey="assertFilterApplied"> | ||
<argument name="resultValue" value="{{AdminMediaGalleryFolderData.name}}"/> | ||
</actionGroup> | ||
</test> | ||
</tests> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.