Skip to content

Issue 36274: Duplicate orders with 2 parallel GraphQL requests #36313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Issue 36274: Duplicate orders with 2 parallel GraphQL requests #36313

wants to merge 7 commits into from

Conversation

rogerdz
Copy link
Contributor

@rogerdz rogerdz commented Oct 17, 2022 •
edited
Loading

Description (*)

Lock cart in 60s before place order

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Duplicate orders with 2 parallel GraphQL requests #36274

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 17, 2022

Hi @rogerdz. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Progress: pending review labels Oct 17, 2022
@rogerdz
Copy link
Contributor Author

rogerdz commented Oct 17, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Oct 17, 2022 •
edited
Loading

We have absolutely the same issue using default checkout (through REST API) #35139, so I think we should think about fixing both cases. And yes, I like the idea with locks.

@rogerdz
Copy link
Contributor Author

rogerdz commented Oct 17, 2022

I updated fix duplicate order for default checkout through REST API
Result:
2022-10-17_23-38

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@rogerdz
Copy link
Contributor Author

rogerdz commented Oct 17, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev
Copy link
Contributor

@rogerdz great job!
The last thing I would ask you, Could you please cover your changes with unit / integration / web api tests?

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@rogerdz
Copy link
Contributor Author

rogerdz commented Oct 18, 2022

@ihor-sviziev I added unit test

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@rogerdz
Copy link
Contributor Author

rogerdz commented Oct 19, 2022

@magento run Unit Tests, Integration Tests, Functional Tests EE, Functional Tests B2B, Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev
ihor-sviziev approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests look not related to changes from this PR.

@ihor-sviziev ihor-sviziev added Award: test coverage Award: bug fix Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Oct 19, 2022
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

2 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Lima
Copy link
Contributor

@magento run Integration Tests ,Static Tests,Unit Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Lima
Copy link
Contributor

Hi @rogerdz ,

Thanks for your contribution and collaboration.

I would like to inform you that we are closing this PR as internal team is working on it and it is fixed as per the jira ticket comment.

Thanks

@engcom-Lima engcom-Lima closed this Nov 2, 2022
@jonathanribas
Copy link

Hi @ihor-sviziev, do you have news regarding this issue?

We are still experiencing it on 2.4.5-p1 :(

It's creating a bad user experience, refunds processed manually by ouf customer service, customers frustration... Lot of manual work for several collaborators.

Thanks for your help.

@ihor-sviziev
Copy link
Contributor

@jonathanribas, as is written above, the internal team has fixed the issue, but the changes weren't included in any release yet. You can find related commits here https://github.com/search?q=repo%3Amagento%2Fmagento2+ACP2E-1194&type=commits

@jonathanribas
Copy link

@ihor-sviziev, no chance to have a Quality Patch for this topic? It's very common to happen in headless integrations...

@ihor-sviziev
Copy link
Contributor

@jonathanribas, sorry, I don't really know. Usually, I'm applying fixes as a custom patch using https://github.com/vaimo/composer-patches
Maybe @sidolov can help with it?

@jonathanribas
Copy link

@ihor-sviziev, I mean https://github.com/magento/quality-patches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate orders with 2 parallel GraphQL requests
4 participants
@rogerdz @ihor-sviziev @engcom-Lima @jonathanribas