Issue #13952 - Duplicate orders with same Quote Id at same time with few time difference.

[fiko]

Description (*)

Two different orders have been placed with very few seconds as time difference with same quote Id.

Fixed Issues (if relevant)

1. Fixes Duplicate orders with same Quote Id at same time with few time difference. #13952

Manual testing scenarios (*)

1. Login as a User
2. Add items to cart and proceed through checkout.
3. Select Any payment method. Not click on place order button
4. Now login to the same account in another system.
5. And proceed to checkout with the same items. Not click on place order button.
6. Now you have to click on place order at the same time with both the systems.
7. one of the screen must return failed
   

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Issue #13952 - Duplicate orders with same Quote Id at same time with few time difference. #35833: Issue Duplicate orders with same Quote Id at same time with few time difference. #13952 - Duplicate orders with same Quote Id at same time with few time difference.

[m2-assistant]

Hi @fiko. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[fiko]

@magento give me test instance

[magento-deployment-service]

Hi @fiko. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @fiko, here is your Magento Instance: https://3022acaf10e15efc772e887049d276eb.instances.magento-community.engineering
Admin access: https://3022acaf10e15efc772e887049d276eb.instances.magento-community.engineering/admin_debe
Login: 31e52b8b
Password: 0b4613ea7fdb

[fiko]

@magento run Database Compare, Static Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[fiko]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[fiko]

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[fiko]

@magento run Integration Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[amine-y]

@ihor-sviziev
Why this ticket is not being taken seriously,
The problem is still happening in active Magento installations

[ihor-sviziev]

@sidolov @sdzhepa, could you take a look, and reply?

[sdzhepa]

Hello @amine-y and @ihor-sviziev

Thank you for raising this issue!

I do not know the reason but looks like this PR was missed because the related issue was closed: #13952

The issue has a huge thread of comments as I can see a patch was provided to fix it: #13952 (comment).
But the overall situation is not clear is it actual for the current 2.4-develop

@engcom-Alfa and @engcom-Charlie Could you please work together to investigate this problem?
Please review in detail the discussion/comments in #13952
Try to reproduce this issue by the steps from this PR.
Try to check if the patch fixes the issue
If the problem still exists please create and confirm the new issue with all required details. Also please link a new issue with this PR and add all other links to comments if required

Depending on the result please process the PR accordingly
cc: @sidolov

[ihor-sviziev]

Hi @fiko,
Please review and fix the test failures.

[fiko]

@magento run Unit Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[fiko]

@magento run WebAPI Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[fiko]

@magento run Unit Tests

will try to check, investigate & fix them next week, last week Unit Test was failed, but it's just succeed.

[fiko]

@magento run WebAPI Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[amine-y]

@magento give me test instance

[magento-deployment-service]

Hi @amine-y. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @amine-y, here is your Magento Instance: https://3022acaf10e15efc772e887049d276eb.instances.magento-community.engineering
Admin access: https://3022acaf10e15efc772e887049d276eb.instances.magento-community.engineering/admin_f4aa
Login: a41241ff
Password: 0b6b130ec7f2

[nishant04412]

Hi @fiko and @ihor-sviziev,

This issue has been taken care in internal JIRA ticket. Once Internal PR will get merged, we will notify it here.

JIRA Ref: https://jira.corp.adobe.com/browse/AC-6057

Thank you!

[Denisof]

Hi @fiko and @ihor-sviziev, The fix is not correct, in case of any quote errors $this->submitQuoteValidator->validateQuote($quote); a user loses active quote.

[nishant04412]

Hello,

The issue got fixed in the scope of the internal Jira ticket AC-6057 by the internal team
Related commits: https://github.com/magento/magento2/search?q=AC-6057&type=commits

Based on the Jira ticket, the target version is 2.4.6.

Thanks

[engcom-Charlie]

Based on above comment, closing this PR.

Thank you!