Skip to content

Simplify product list #6881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Simplify product list #6881

wants to merge 2 commits into from

Conversation

slackerzz
Copy link
Member

@slackerzz slackerzz commented Oct 5, 2016

Following the KISS principle we can save some CPU cycles

Followinf the KISS principle we can save some CPU cycles
@dverkade
Copy link
Member

dverkade commented Oct 6, 2016

Hi Slackerzz,

What a great find! :-) I see there are a total of 16 instances of this code in different templates. Any change you want to fix them as well?

@slackerzz
Copy link
Member Author

Ok, i'm going to "fix 'em all"

@vrann
Copy link
Contributor

vrann commented Mar 25, 2017

@slackerzz can you please synchronize your branch with the latest develop?

@slackerzz
Copy link
Member Author

@vrann i've just opened a new pull request #9019 based on current develop branch (i've accidentally deleted the old fork with this branch)

@slackerzz slackerzz closed this Mar 26, 2017
@vrann vrann added this to the March 2017 milestone Mar 27, 2017
@vrann vrann assigned vrann and unassigned eug123 and odubovyk Mar 27, 2017
magento-engcom-team pushed a commit that referenced this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants