simplify product lists #2 #9019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
added 2 commits
July 13, 2017 17:52
Conflicts: app/code/Magento/Catalog/view/frontend/templates/product/list.phtml app/code/Magento/Catalog/view/frontend/templates/product/list/items.phtml app/code/Magento/Catalog/view/frontend/templates/product/listing.phtml app/code/Magento/Catalog/view/frontend/templates/product/widget/new/column/new_default_list.phtml app/code/Magento/Catalog/view/frontend/templates/product/widget/new/content/new_grid.phtml app/code/Magento/Catalog/view/frontend/templates/product/widget/new/content/new_list.phtml app/code/Magento/CatalogWidget/view/frontend/templates/product/widget/content/grid.phtml app/code/Magento/Reports/view/frontend/templates/widget/compared/column/compared_default_list.phtml app/code/Magento/Reports/view/frontend/templates/widget/compared/content/compared_grid.phtml app/code/Magento/Reports/view/frontend/templates/widget/compared/content/compared_list.phtml app/code/Magento/Reports/view/frontend/templates/widget/viewed/column/viewed_default_list.phtml app/code/Magento/Reports/view/frontend/templates/widget/viewed/column/viewed_images_list.phtml app/code/Magento/Reports/view/frontend/templates/widget/viewed/content/viewed_grid.phtml app/code/Magento/Reports/view/frontend/templates/widget/viewed/content/viewed_list.phtml app/code/Magento/Wishlist/view/frontend/templates/item/list.phtml
magento-team
pushed a commit
that referenced
this pull request
Jul 18, 2017
magento-team
pushed a commit
that referenced
this pull request
Jul 18, 2017
[EngCom] Public Pull Requests - MAGETWO-70817: remove redundant else and use strict check #10271 - MAGETWO-70787: update phpserver to support versioned static urls #10250 - MAGETWO-70764: Fix overwrite default value image/file with NULL #10253 - MAGETWO-70761: Show values that are duplicate in attribute error msg #10213 - MAGETWO-70758: Fix for #4530 $product->getRatingSummary() always returns null […] #10248 - MAGETWO-70706: simplify product lists #2 #9019 - MAGETWO-70669: Fix fatal errors with deleteOptionsAndSelections #7711 - MAGETWO-70464: Fix shipping address can use for billing #10130 - MAGETWO-69913: magento/magento2 #9196 - Products ordered report doesn't show simple (child) products of configurable products #9908
|
This PR broke the product grid in Luma / blank themes — grids use inline-block method and thus cannot contain whitespace. I agree the previous solution was ugly (way overkill). Imo the nicest solution is to comment out any whitespace using HTML comment tags. The other solution is to use the font-size 0 trick, but I'm not a fan due to the complex CSS required. I'll create PR. |
|
Ah, there's already an issue: #19312 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated my old pull request #6881 in order to resolve conflicts