Fix fatal errors with deleteOptionsAndSelections

[kassner]

Magento\BundleImportExport\Model\Import\Product\Type\Bundle::deleteOptionsAndSelections had no love during code convertion. Throws fatal errors because columns does not exist. Method refactored to work as expected.

[vrann]

@kassner unfortunately, we don't process PRs to 2.1 branch at the moment. Please re-create it against develop branch.

[kassner]

@vrann can you reopen? GitHub allows to rebase the PR from the interface.

[vrann]

@kassner can you merge with the latest develop? There are conflicts right now.

[kassner]

@vrann Done.

[vrann]

@kassner trying to reproduce the issue. Can you please provide steps and some sample data (i.e. file from which to import)

[kassner]

@vrann I can provide a descriptive way of reproducing it next week, but is quite easy to see the problem at naked eye: catalog_product_bundle_option doesn't have value_id or parent_product_id columns. Basically anything that calls deleteOptionsAndSelections will result in a fatal error.

[kassner]

@vrann Well, I can't provide a working example, because it looks like this part is never executed in normal conditions, since saveData is only called when saving a product (Add/Update or Replace behaviours), so it never goes inside that if, since it looks for the Delete behaviour.

Can, instead, I remove this code on this PR, since it isn't used at all? If not, just close this PR. We have this issue internally, but deleteOptionsAndSelections is called on replace (I can't tell the reasons, I didn't work on that part).

Thanks!

[vrann]

@kassner I see that the joined table catalog_product_bundle_option has column parent_id while catalog_product_bundle_option_value which is used in FROM part of the query has column value_id. So it should be possible to select value_id and filter by parent_id. Am I missing something?

I would keep that section because DELETE behavior can always be set to entity model before invocation of saveData()

[kassner]

@vrann The join is correct, but that is only used to populate $valueIds. The problem takes place when $this->connection->delete is called. Example:

magento2/app/code/Magento/BundleImportExport/Model/Import/Product/Type/Bundle.php

Lines 645 to 648 in c30a05a

	$this->connection->delete(
	$optionTable,
	$this->connection->quoteInto('value_id IN (?)', array_keys($valuesIds))
	);

This code is deleting from $optionTable (which resolves to catalog_product_bundle_option), but that table does not have value_id. In the end, all the 3 calls to $this->connection->delete are deleting from $optionTable instead of the correct ones.

[okorshenko]

Hi @kassner
If you would like to proceed with this PR, could you please add integration test to this file to cover your use case https://github.com/magento/magento2/blob/develop/dev/tests/integration/testsuite/Magento/BundleImportExport/Model/Import/Product/Type/BundleTest.php ?
Thank you
Please let me know if you need some help

[kassner]

@okorshenko I will not put more hours into this issue, up to you to merge or close.

[okorshenko]

Hi @kassner We will add tests on our side. Thank you for your contribution.

[Ctucker9233]

@magento-team This PR Doesn't appear to be in 2.2. Should it be backported?