Checked users status before applying during newsletter edit from my accont#712
Closed
tmukherjee13 wants to merge 1 commit intomagento:masterfrom
Closed
Checked users status before applying during newsletter edit from my accont#712tmukherjee13 wants to merge 1 commit intomagento:masterfrom
tmukherjee13 wants to merge 1 commit intomagento:masterfrom
Conversation
Contributor
|
Thank you for your suggestion! We will review your contribution and get back to you once we have the answer. |
Contributor
|
Hi @tmukherjee13, thank you for you PR. Can you please review it and if it still actual, resubmit it into develop branch, also with checking travis builds. Thanks. |
Contributor
|
Resolution: reject, due inactivity from creator. |
mmansoor-magento
pushed a commit
that referenced
this pull request
Jan 5, 2017
Story: - MAGETWO-52856: [WebAPI] Improve WebAPI performance of Checkout Payment Info/Place order call Bug: - MAGETWO-62856: JSUnit job is failed on current mainline Task: - MAGETWO-62968: Mark unstable test "RegisterCustomerFrontendEntityTest"
magento-engcom-team
added a commit
that referenced
this pull request
Jul 30, 2019
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users go to the edit Manage Newsletter section from their Account. After clicking on the Submit button the message is shown regarding "changes are saved" even if they never change anything. Just added a condition before making changes to avoid unnecessary messages and transactions.