Skip to content

Conversation

@jjerphan
Copy link
Member

@jjerphan jjerphan commented Jan 12, 2026

Description

catch2 3.8 was used but newer versions requires changes, mostly for tests execution as of 3.9.

(The update to catch2 3.12 published yesterday with conda-forge/catch2-feedstock#75 triggered failures on the CI even though other versions between 3.8 and 3.12 have been available for a while on conda-forge.)

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@jjerphan jjerphan changed the title test: Changes from catch2 >3.8 test: Changes for catch2 >3.8 Jan 12, 2026
@github-actions github-actions bot added the release::maintenance For PRs related to maintenance label Jan 12, 2026
@jjerphan jjerphan force-pushed the test/changes-catch2-gt-3.8 branch 2 times, most recently from 55318ac to 3cc7965 Compare January 12, 2026 16:12
@jjerphan jjerphan mentioned this pull request Jan 12, 2026
11 tasks
@jjerphan jjerphan marked this pull request as ready for review January 12, 2026 16:13
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.11%. Comparing base (d9ca597) to head (b368524).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...mamba/tests/libmamba_logging/test_main_logging.cpp 0.00% 7 Missing ⚠️
libmamba/tests/src/test_main.cpp 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main    #4134       +/-   ##
==========================================
+ Coverage   4.19%   63.11%   +58.92%     
==========================================
  Files        315      316        +1     
  Lines      38777    38806       +29     
  Branches    2996     2986       -10     
==========================================
+ Hits        1625    24494    +22869     
+ Misses     37149    14241    -22908     
- Partials       3       71       +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very minor suggestions below, you can ignore

jjerphan and others added 4 commits January 12, 2026 18:11
Signed-off-by: Julien Jerphanion <[email protected]>

Co-authored-by: Ben Mares <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>

Co-authored-by: Klaim <[email protected]>
Copy link
Member

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjerphan jjerphan mentioned this pull request Jan 13, 2026
11 tasks
@jjerphan jjerphan merged commit 4a5f083 into mamba-org:main Jan 13, 2026
33 of 37 checks passed
@jjerphan jjerphan deleted the test/changes-catch2-gt-3.8 branch January 13, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::maintenance For PRs related to maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants