-
Notifications
You must be signed in to change notification settings - Fork 425
test: Changes for catch2 >3.8 #4134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
55318ac to
3cc7965
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4134 +/- ##
==========================================
+ Coverage 4.19% 63.11% +58.92%
==========================================
Files 315 316 +1
Lines 38777 38806 +29
Branches 2996 2986 -10
==========================================
+ Hits 1625 24494 +22869
+ Misses 37149 14241 -22908
- Partials 3 71 +68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Klaim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, very minor suggestions below, you can ignore
Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Ben Mares <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Klaim <[email protected]>
Klaim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
catch2 3.8 was used but newer versions requires changes, mostly for tests execution as of 3.9.
(The update to catch2 3.12 published yesterday with conda-forge/catch2-feedstock#75 triggered failures on the CI even though other versions between 3.8 and 3.12 have been available for a while on conda-forge.)
Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.