This repository was archived by the owner on Dec 28, 2025. It is now read-only.
Add document and resource rootschema properties #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
- Coverage 92.62% 91.10% -1.52%
==========================================
Files 23 21 -2
Lines 2033 2002 -31
Branches 428 428
==========================================
- Hits 1883 1824 -59
- Misses 97 118 +21
- Partials 53 60 +7
☔ View full report in Codecov by Sentry. |
handrews
force-pushed
the
rootschema
branch
2 times, most recently
from
22dd3ac to
7ad06d2
Compare
Finding the document root is needed for resolving references as proposed in order to support mutually referencing schema bundles. The current proposal requires ensuring that either a schema document is all-resolved or all-not-resolved.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[EDIT: I figured out a much less convoluted way to handle #76, so this is no longer strictly necessary. These accessors might be useful as part of the public API, so I'm leaving the PR up, but if they don't fit with the API design it's fine to just close this.]
Finding the document root is needed for resolving references as proposed in order to support mutually referencing schema bundles per issue #76, but it stands on its own and the properties might be useful regardless of how that issue is (or isn't) solved.
The current proposal in #76 requires ensuring that either a schema document is all-resolved or all-not-resolved, to avoid unpredictable reference resolution errors during evaluation. Exactly how and why this is needed will be more clear if/when I post a PR for the whole solution.