More tests for the Catalog

[handrews]

I added these while working on #71, but they really have nothing to do with that change so I split them into this separate PR. The context manager tests account for most of the not-previously covered lines in catalog/__init__.py

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: +0.37 🎉

Comparison is base (f5df6c4) 91.56% compared to head (af502f6) 91.93%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   91.56%   91.93%   +0.37%     
==========================================
  Files          21       21              
  Lines        2003     1972      -31     
  Branches      427      370      -57     
==========================================
- Hits         1834     1813      -21     
+ Misses        110      101       -9     
+ Partials       59       58       -1     

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[handrews]

@marksparkza I've rebased this and #72 for 0.10.1 as we previously discussed. I'm not sure what happened with the tests timing out, as I just re-ran the full suite locally without problems. It doesn't look like I can make them run again, but I suspect they would pass.

Fixing the new-style output (#88) and implementing the "list" format might take some time. I'm not 100% over COVID and I have a contract starting this week that will take priority.

[marksparkza]

@handrews, thanks and no problem. In that case once 72 is merged I'll release 0.10.1. I've not had a good look through the remaining PRs yet, but if there are any relatively simple ones I might do one or two further 0.10.x patch releases. My time is quite constrained for the foreseeable future so it might take a while to get through the more complex stuff. In any case, thanks very much for your contributions so far - it's been great quality work, and it's great to have an active contributor on board!

[handrews]

@marksparkza sounds good- I'll go ahead and rebase everything just to clear the conflicts, but here are the PRs you might want to consider for patch releases:

• Add document and resource rootschema properties #78 pretty straightforward although non-essential
• Support discouraged but allowed "$id" values #80 this is more simple than it looks at first glance and technically a bugfix (the official test suite doesn't catch this bug)
• "integer" is not a keyword restriction type #84 trivial, if you want it at all
• Docstrings for Source classes and other things #90 just a few docstring additions
• More info about the Catalog in the tutorial #91 tutorial additions that go with PR 90, although it's probably too much writing to read through (and maybe too opinionated) for a quick patch release approval which is why I split them

Three of the other four PRs are related to very complex reference loading situations, and the fourth is for switching $schema values in subschemas with $id. Those should all go to 0.11.0. The $schema one ended up being relatively straightforward, so you could make that 0.11.0 and defer the complex referencing to 0.12.0 if you only have time for one complex thing.