This repository was archived by the owner on Dec 28, 2025. It is now read-only.
"integer" is not a keyword restriction type #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keywords can only be restricted to JSON data model types.
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 92.08% 92.17% +0.08%
==========================================
Files 21 21
Lines 2010 2006 -4
Branches 429 427 -2
==========================================
- Hits 1851 1849 -2
+ Misses 101 100 -1
+ Partials 58 57 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81, if there's a desire to "fix" it: Keywords can only be restricted to JSON data model types.
The extension keyword API is not an area where people test for compliance, so I'd be equally happy with documenting that
"integer"as an evaluation restriction is ajschonextension, and could post a PR for that if desired. I would also not be upset if this and #81 are just closed and things are left as-is.