[BUG]: "Next unread article" + "Keep message selection in the middle"

[sakkamade]

Brief description of the issue.

When the option "Keep message selection in the middle of the article list viewport" is enabled, choosing "Next unread article" producing eccentric and buggy behaviour.

How to reproduce the bug?

1. Enable "Keep message selection in the middle of the article list viewport"
2. Either click the action in toolbar or assigned key of "Next unread article"
   • Some bizarre flickering already reveal itself
3. Press Arrow Down
   • Observe how the highlight of the entry stay on top of the list while selected article is actually in the middle

What was the expected result?

As the action "Next unread article" is executed, and the "Keep message selection in the middle of the article list viewport" is enabled, selected article must adhere to the middle (or to the top as happy medium) of the list, and closer to top or bottom upon demand, if entry in the list is at respective position.

After "Next unread article" is executed, the highlight must duly move by Arrow keys.

All in all, behaviour of aforementioned options should be concordant.

What actually happened?

rss-guard-list.mp4

Other information

• OS: Arch Linux, KDE
• RSS Guard
  Version: 4.0.0 (built on Linux/x86_64)
  Revision: 21577df
  Build date: 10/06/2021 03:28
  Qt: 5.15.2 (compiled against 5.15.2)

[martinrotter]

I commited hopeful fix, can you test after build compiles?

[sakkamade]

#439 (comment)

Hahaha. Sorry about that... (Missed right issue.)

rss.scroll.mp4

[martinrotter]

So are you saying it is wrong still? Is this with "Keep ... center..." enabled?

[martinrotter]

Here is my video:

Looks pretty much OK. If I have centering enabled, selection tries to be at center, if not, then it sticks to the TOP (when using next/previous/unread message feature) to keep old behavior.

[sakkamade]

So are you saying it is wrong still?

Yes, it is.

Is this with "Keep ... center..." enabled?

Yes, with enabled.

If I have centering enabled, selection tries to be at center,

Yes, it tries; however as you can see in #435 (comment), if I clicked "Next Unread" and then start to simply move selection by Arrow Up/Down the selection's highlight adhere to the top of the list, i.e. this is still present:

3. Press Arrow Down

• Observe how the highlight of the entry stay on top of the list while selected article is actually in the middle

[sakkamade]

Here's another screencast, which hopefully will be more plain:

keep.RSS.Guard.mp4

And while I was at it, I noted another certain something:

feed.list.RSS.Guard.mp4

You can observe that not before I click "Next unread" the feed list displays the same behaviour as articles list used to.
However, in this case, I should prefer that it befall no change whatsoever.

[martinrotter]

This must somehow be visible on Linux/KDE only. On windows behavior from videos does not happen.

I will test on Linux at home tonight probably.

[martinrotter]

does same behavior happen when you use "Select next article" instead of "Select next unread article"