Fix pinned carousel scroll on mobile #34858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
approved these changes
May 30, 2025
ChaosExAnima
added
bug
| touch-action: pan-x; | ||
| touch-action: pan-y; |
There was a problem hiding this comment.
TIL! So basically, this declaration specifies which direction we want to keep being handled natively, while horizontal scrolling is prevented & handled by JS? Seems like it could use a comment as it's very counter-intuitive.
There was a problem hiding this comment.
agreed about a comment, but thankfully if anyone removes it there'll be a warning in the console leading here: https://use-gesture.netlify.app/docs/extras/#touch-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34852. The direction on the
touch-actionattribute was incorrect.