Skip to content

Fix pinned carousel scroll on mobile #34858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Fix pinned carousel scroll on mobile #34858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/javascript/styles/mastodon/components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11044,7 +11044,7 @@ noscript {
overflow: hidden;
flex-shrink: 0;
border-bottom: 1px solid var(--background-border-color);
touch-action: pan-x;
touch-action: pan-y;
Copy link
Contributor

@diondiondion diondiondion May 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! So basically, this declaration specifies which direction we want to keep being handled natively, while horizontal scrolling is prevented & handled by JS? Seems like it could use a comment as it's very counter-intuitive.

Copy link
Contributor Author

@ChaosExAnima ChaosExAnima May 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed about a comment, but thankfully if anyone removes it there'll be a warning in the console leading here: https://use-gesture.netlify.app/docs/extras/#touch-action


&__slides {
display: flex;
Expand Down