Open
Conversation
added 30 commits
September 21, 2025 20:02
added 12 commits
September 21, 2025 20:31
sgiehl
reviewed
Nov 19, 2025
| 'BEL' => 'Bell', | ||
| '9B' => 'Bellphone', | ||
| '63' => 'Beyond', | ||
| 'BG' => 'BGH', |
Member
There was a problem hiding this comment.
We should not remove records from the listing in general. Matomo internally only stores the short codes. Might cause problems. So maybe instead of removing the records, just add a comment after the line that it's not used anymore and only kept for BC reasons.
Contributor
Author
There was a problem hiding this comment.
I already suggested and committed and approach in my comments in #8109 😅
Member
There was a problem hiding this comment.
Ah sorry, I'm a bit short in time currently and don't have enough time to observe all changes here. Guess I missed it
…nto NamesClarifications # Conflicts: # Parser/Device/AbstractDeviceParser.php # Tests/fixtures/smartphone-39.yml # Tests/fixtures/smartphone-41.yml # regexes/device/mobiles.yml
Contributor
Author
|
Added legacy brands array to align with #8109, so ready for proper review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Split from #8096 this covers name changes where name was changed to clarify specific brand (abbreviation expanded, postfix added/removed, etc.)
Review