Skip to content

2.0.0 #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
15 of 20 tasks
gjrtimmer opened this issue Jun 15, 2018 · 15 comments
Closed
15 of 20 tasks

2.0.0 #598

gjrtimmer opened this issue Jun 15, 2018 · 15 comments
Assignees
Milestone

Comments

@gjrtimmer
Copy link
Collaborator

gjrtimmer commented Jun 15, 2018

Go-SQLite3 v2.0.0

WORK IN PROGRESS

Please Submit Your Wishes / Requests

Planned Updates

  • Add Context to errors More Information
  • Add additional tests for provided options
  • Fix Extension loading; current when a module cannot be found it returns an unknown error 115 from SQLite; provided more error information which extension could not be loaded.
  • Implement Golang:1.10 SQL Connector
  • Rewrite connection configuration
  • See if sqlite3.go can be split on a functional level with moving to code for statements to its own file
  • Update Examples
  • Research if in combination with new configuration if the DSN connection can be configured with options without a _ prefix.
  • Add more comments to explain workings to allow easier contribution
  • Add contributing guide
  • Increase code coverage
  • Implement Golang project layout

Tests

Write additional tests

  • Foreign Keys
  • FTS5
  • ICU
  • Introspect
  • JSON1
  • Secure Delete (If possible)
  • Stat4
  • User Auth
@gjrtimmer gjrtimmer added this to the 2.0.0 milestone Jun 15, 2018
@gjrtimmer gjrtimmer self-assigned this Jun 15, 2018
gjrtimmer added a commit to gjrtimmer/go-sqlite3 that referenced this issue Jun 26, 2018
* Implementation for RegisterCryptProvider
* Separated

mattn#598
gjrtimmer added a commit that referenced this issue Jun 26, 2018
* Add Test

#598
gjrtimmer added a commit to gjrtimmer/go-sqlite3 that referenced this issue Jun 27, 2018
gjrtimmer added a commit to gjrtimmer/go-sqlite3 that referenced this issue Jun 27, 2018
* Add TestTransactionConn

mattn#598
gjrtimmer added a commit to gjrtimmer/go-sqlite3 that referenced this issue Jul 3, 2018
gjrtimmer added a commit to gjrtimmer/go-sqlite3 that referenced this issue Jul 3, 2018
gjrtimmer added a commit that referenced this issue Jul 3, 2018
@gjrtimmer
Copy link
Collaborator Author

@mattn Please checkout and take a look, documentation is not done yet. Can you provide some feedback for me ?

@mattn
Copy link
Owner

mattn commented Jul 3, 2018

Thanks your great works. I'm thinking all of tasks are not required for 2.0.0 .

@gjrtimmer
Copy link
Collaborator Author

@mattn Will update the tasks

@gjrtimmer
Copy link
Collaborator Author

@mattn I will complete the 2.0.0 and incorporate all the current missing items like documentation.

@gjrtimmer
Copy link
Collaborator Author

@mattn I would like to know how do you feel about introducing a dependency on github.com/pkg/errors so we can wrap errors and provide more and better error information.

@mattn
Copy link
Owner

mattn commented Jul 12, 2018

I don't have strong opinion but what the use-case?

@y4dkit
Copy link

y4dkit commented Jul 12, 2018

Is there a support for Update Hook? (https://www.sqlite.org/c3ref/update_hook.html)

Is it possible to set a callback to be called whenever I insert, update or delete?

@gjrtimmer
Copy link
Collaborator Author

@mattn Use case is to better track down errors; we can add an additional context error where it occurs. So when printing the stacktrace you can better track down where it originated.

@gjrtimmer
Copy link
Collaborator Author

@y4dkit Will look into it; I will try so see if I at least can inject the open Pre-Update Hook.
Have you written an example for the update hook maybe ?

gjrtimmer added a commit to gjrtimmer/go-sqlite3 that referenced this issue Jul 20, 2018
Closes mattn#597
Closes mattn#598
gjrtimmer added a commit to gjrtimmer/go-sqlite3 that referenced this issue Jul 20, 2018
Closes mattn#597
Closes mattn#598
gjrtimmer added a commit that referenced this issue Jul 20, 2018
Closes #597
Closes #598

All documentation in Wiki
gjrtimmer added a commit that referenced this issue Jul 20, 2018
Closes #597
Closes #598

All documentation in Wiki
Update Examples
gjrtimmer added a commit to gjrtimmer/go-sqlite3 that referenced this issue Jul 20, 2018
Closes mattn#597
Closes mattn#598

All documentation in Wiki
Update Examples
gjrtimmer added a commit that referenced this issue Jul 20, 2018
Closes #597
Closes #598

All documentation in Wiki
Update Examples
gjrtimmer added a commit to gjrtimmer/go-sqlite3 that referenced this issue Jul 20, 2018
Closes mattn#597
Closes mattn#598

All documentation in Wiki
Update Examples
gjrtimmer added a commit that referenced this issue Jul 20, 2018
Closes #597
Closes #598

All documentation in Wiki
Update Examples
gjrtimmer added a commit to gjrtimmer/go-sqlite3 that referenced this issue Jul 20, 2018
Closes mattn#597
Closes mattn#598

All documentation in Wiki
Update Examples
gjrtimmer added a commit that referenced this issue Jul 20, 2018
Closes #597
Closes #598

* All documentation in Wiki
* Update Examples
* Fix EOL
* Fix CI
@gjrtimmer gjrtimmer mentioned this issue Jul 20, 2018
@coreybutler
Copy link
Contributor

I've been using the update hook in the following manner, which has worked reasonably well in the majority of circumstances:

image

The problem is pretty simple though... tables created without rowid pose a problem, because (obviously) there is no rowid.

Typically, my apps need to use the data in some manner. A common scenario is inserting a record and, then re-querying the DB to retrieve the row that was inserted. It would be nice if there were a reference to the whole row(s) instead of re-querying the DB. Perhaps there's a more elegant way, but I would love to see a map[string]interface{} representing the entire record instead of just the rowid. This would a) not be rowid dependent and b) supports this type of use case.

@rittneje
Copy link
Collaborator

RegisterUpdateHook is just a wrapper around sqlite3_update_hook. It sounds to me like this is a feature request for SQLite itself, not this library. I suggest posting on the mailing list.

@coreybutler
Copy link
Contributor

@rittneje ah, I see... it does indeed seem like a feature request for sqlite, not this project.

@AlekSi
Copy link
Contributor

AlekSi commented Jan 23, 2020

I would like v2 be compatible with Go modules.

@powerjungle
Copy link

Shouldn't this be added to the list as well? #802
It's kinda weird leaving ORDER BY and LIMIT behind.

@mattn mattn closed this as completed Feb 17, 2022
@mattn
Copy link
Owner

mattn commented Feb 17, 2022

This isn't working, at least not the latest. I would like to thank to gjrtimmer for challenging this change. Unfortunately this didn't match my intentions. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants