v2.0.0 #611

gjrtimmer · 2018-07-20T14:35:11Z

Update driver to v2.0.0

Complete Rewrite
Move all documentation to Wiki
Extendend documentation
Repaired examples
Provided README for all examples including build commands
Implemented Golang Project layout
Implemented Pre-Update Hook from Add support for pre-update hooks #597
Written Additional Tests
Increased coverage
Implemented missing functionality for Go:1.10.x
- *Config
- driver.Connector
- driver.DriverContext
Rewrite of DNS Options
Rewrite of CryptEncoder
- User can now easily create own CryptEncoder and register is with the driver so it can be used from the DSN.
Added support for PPC Architecture
Rewrite of the BackupTests because o Go:1.8
Add tests for several features
Fix race error
Added GitHub Templates

This will close PR #597 and Issue #598

* Replaced normal error with `Error` and SQLite return code. * Fix tests

* Add test * Fix AuthEnabled() * Add AuthEnabled() to TestUserAuthCreateDatabase()

* Add Tests * Fix Compile time option

Fix Travis-CI for new project layout.

Included fix 306. Closes #306

gjrtimmer · 2018-07-20T14:36:14Z

This requires manual merge because the master has to be overwritten with this new branch.

@mattn If you want I can do the merge after your approval. It requires a forced push to the master

gjrtimmer · 2018-07-20T14:39:39Z

PR #439 and PR #487 will be done in the new v2.0.0; I will do those by hand and close the corresponding PR.

mattn · 2018-07-20T16:23:48Z

I prefer to use error message leading with lower case letters. For example: failed to ... not Failed to .... If I had wrote upper case, please fix in this PR.

gjrtimmer · 2018-07-21T13:30:19Z

I understand not a problem. I will fix this and add it to the contributing guide. Anything else you want or prefer? I honestly don't mind because you started this great repo. Any rules or requirements you want shall be added to the contributing guide which I have added in this PR.

mattn · 2018-07-23T05:00:11Z

As far as I can see, patckage path is moved to driver directory, So this break compatibility?

gjrtimmer · 2018-07-23T08:18:51Z

Yes, and second what breaks backwards compatibility are the names of the DSN. No longer is prefix '_' required for the options within the DSN, because there are no conflicts between the options of SQLite and this package.

Check out the Wiki.

Closes #450 [skip ci]

gjrtimmer · 2018-07-23T08:33:00Z

@mattn Also several options for the DSN have been renamed. _auth_user for example is now simple user. On the Wiki page of the DSN I have even created a conversion list between pre-2.0.0 versions and the 2.0.0 version.

See Conversion List

gjrtimmer · 2018-07-23T08:36:19Z

Also _loc is now fully implemented as tz (Timezone). Within the DSN as well within the Config.

mattn · 2018-07-23T08:42:17Z

I'm feeling that the impact of this breaking backward compatibility for third party packages is too big. Most of app or packages using go-sqlite3 is not managed by package manager like glide, dep or vgo. I wonder this proposal requires somewhat unreasonable work for users. May be, we will get many vote down comments. :-(

So, how about to separate repository? Move to github.com/go-sqlite3/v1 or v2, Or use pkg.in ?

BTW, your works is great. Thanks.

gjrtimmer · 2018-07-23T10:19:45Z

@mattn Thanks. We could do a separate repository however I'm not a fan for it.
I do not think that we will receive a lot of votes down.

We have significantly increased the documentation. Provided conversion tables and we follow Semantic Versioning. We because things are not entirely backwards compatible we increased the Major version to 2.

Users can also always checkout tag 1.9.0; I honestly think users will be happy with a major update. I think we should update it and if we really get much backfire; we can either look into a rollback or providing the community with additional conversion documentation.

gjrtimmer · 2018-07-23T11:47:28Z

BTW, Native full encryption (SEE), build upon the v.2.0.0 is almost done

gjrtimmer · 2018-07-23T12:14:02Z

@mattn see previous post; If we really get to many complaints we always can create the separate repository like to suggest after the complaints; I really think we should update it and just see.

Adding a large text to the beginning to the README as a warning about the backwards compatibility should help to.

gjrtimmer · 2018-07-24T09:37:08Z

@mattn Any thought yet.

P.S. I've completed SEE native Golang encryption by incorperating any other repo and makes quite some change to get it all working. But it is working perfectly. Also I have several other updates ready.

mattn · 2018-07-24T10:37:03Z

Could you please explain all of differences between v1 and v2 ? I want to know how many breaking backword compatibilities. Thanks.

gjrtimmer · 2018-07-24T10:42:24Z

@mattn

_ Prefix removed from DSN configuration keys
Renamed DSN config key loc to tz and added timezone as alternative
Dropped config key _auth
Removed prefix _auth_ from UserAuthentication config keys
Implemented Golang project structure; moved the driver to folder driver, this changes the import path. package name sqlite3 remains the same. Import path is now github.com/mattn/go-sqlite3/driver

Pre-2.0.0	2.x
cache	cache
mutex	mutex
_auth	N.A.
_auth_user	user
_auth_pass	pass
_auth_salt	salt
_auth_crypt	crypt
_auto_vacuum	auto_vacuum
_busy_timeout	busy_timeout
_case_sensitive_like	case_sensitive_like
_cslike	cslike
_defer_foreign_keys	defer_foreign_keys
_defer_fk	defer_fk
_foreign_keys	foreign_keys
_fk	fk
_ignore_check_constraints	ignore_check_constraints
_journal_mode	journal_mode
_journal	journal
_loc	tz, timezone
_locking_mode	locking_mode
_locking	locking
_query_only	query_only
_recursive_triggers	recursive_triggers
_rt	rt
_secure_delete	secure_delete
_synchronous	synchronous
_sync	sync
_timeout	timeout
_txlock	txlock
_vacuum	vacuum
_writable_schema	writable_schema

Additional documentation moved from README to Wiki Pages.

mattn · 2018-07-24T10:51:36Z

_ Prefix removed from DSN configuration keys

I'm thinking this might occur problem when sqlite include new flag which have same name in go-sqlite3.

Implemented Golang project structure; moved the driver to folder driver, this changes the import path. package name sqlite3 remains the same. Import path is now github.com/mattn/go-sqlite3/driver

Sorry, I still not understand well why this is needed.

gjrtimmer · 2018-07-24T11:13:06Z

_ Prefix removed from DSN configuration keys

I'm thinking this might occur problem when sqlite include new flag which have same name in go-sqlite3.

The chance that a conflict will arise will be small because the keys that are given to SQLite are for low-level configuration. Currently there is no such change on the roadmap. Second if their might be a conflict in the future we can easily change it. I think however that the chance will be extremely slim that we will have a conflict in the future.

Implemented Golang project structure; moved the driver to folder driver, this changes the import path. package name sqlite3 remains the same. Import path is now github.com/mattn/go-sqlite3/driver

Sorry, I still not understand well why this is needed.

This was done by my choice, I you want to revert it; it will be fine. To explain my decision. This layout will give us the opportunity to add additional folders and applications, libraries to the project.

What I was thinking about is to add a Web UI service / Shell to the project in the future. In which you could manage your SQLite database. Available as shell program and library so you can embed it within you project. If you look at the README of Golang Project Layout then you will see where I got the idea.

I've done it with my eye on the future to expand en develop this repository even further. If you do not want this. It will be fine with me.

I was just looking toward the future, and version v2.0.0 gave me a chance to make some big changes. That's all there is to it.

gjrtimmer · 2018-07-24T13:54:03Z

@mattn See previous post for explanation.

@mattn If you want to see the end result. I've updated the master of my own fork to v2.0.0 including the latest fixes for the features from fix/features as well as the new SEE full database encryption.

You can find the documentation for it within my Wiki Pages. I hope you like it. Take a look

gjrtimmer · 2018-07-26T07:23:10Z

@mattn within my own repo I've reversed the SEE; this requires some additional work.

mattn · 2018-07-27T03:51:37Z

What I was thinking about is to add a Web UI service / Shell to the project in the future. In which you could manage your SQLite database. Available as shell program and library so you can embed it within you project. If you look at the README of Golang Project Layout then you will see where I got the idea.

I prefer to add cmd/sqlite-shell or something. I am concerned about changing the import path.

Since I am conservative, I always think that I would like to prevent existing users from asking for changes.

Please give me more time to think about this.

gjrtimmer · 2018-07-27T08:02:46Z

@mattn Not a problem take all the time you need. Please check out other SQL drivers like; Postgres, MySQL maybe those will help you choose what to do.

Journal Mode should only be enforced when the user set it. Fixes: #607

strip old SEE Code

gjrtimmer added 30 commits June 13, 2018 16:45

FIx CGO Format

1592d36

Fix: UserAuth Error

1549ea7

* Replaced normal error with `Error` and SQLite return code. * Fix tests

Removed legacy build tags

dc9d5d0

Add Tests for UserAuth Omit

de6249d

* Add test * Fix AuthEnabled() * Add AuthEnabled() to TestUserAuthCreateDatabase()

Update Introspect

9e093e4

* Add Tests * Fix Compile time option

UserAuth: Fix Coverage

204cdb4

Stat4: Add Test

4c7a9b4

UserAuth: Fix Coverage

c7b624f

Stat4: Fix filename

6e0ffca

Group OS compiler flags

c0b3dea

Rewrite

1fa3dcb

Fix upgrade tool

355ec13

Fix Travis-CI

8221c65

Fix Travis-CI for new project layout.

Rewrite

2866d28

Add backup

6dc5ec6

Update result

32a680c

add tests

fa6e997

fix/306

a4cd81b

Included fix 306. Closes #306

add tests

abb3d34

Update result

7157abb

Add Extension(s) loading

be463d8

Add trace

79fc5c4

Fix copyright

0458206

Add entension(s) loading

e1d3dc3

add vtable

b05cf3c

Add optional extensions/modules/config

7f30bcf

Update Copyright

203ba1b

Moved Version Test

026dd10

Moved Transaction Test

81906d7

Moved Pinger test

aad2387

gjrtimmer requested a review from mattn July 20, 2018 14:35

gjrtimmer added 2 commits July 22, 2018 22:32

Rewrite all errors to lowercase.

3af8796

Update CONTRIBUTING GUIDE

35f5717

Close Issue on Merge

4049232

Closes #450 [skip ci]

gjrtimmer added 2 commits August 2, 2018 11:45

fix: journal mode

cf26002

Journal Mode should only be enforced when the user set it. Fixes: #607

fix: journal

e904eb4

strip old SEE Code

mattn closed this Nov 14, 2019

mattn deleted the v2.0.0 branch November 14, 2019 01:02

mattn mentioned this pull request Nov 18, 2019

proxy.golang.org returning 410 for k8s.io/[email protected]+incompatible golang/go#33558

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v2.0.0 #611

v2.0.0 #611

gjrtimmer commented Jul 20, 2018 •

edited

Loading

gjrtimmer commented Jul 20, 2018 •

edited

Loading

gjrtimmer commented Jul 20, 2018

mattn commented Jul 20, 2018

gjrtimmer commented Jul 21, 2018

mattn commented Jul 23, 2018

gjrtimmer commented Jul 23, 2018 •

edited

Loading

gjrtimmer commented Jul 23, 2018

gjrtimmer commented Jul 23, 2018

mattn commented Jul 23, 2018

gjrtimmer commented Jul 23, 2018

gjrtimmer commented Jul 23, 2018

gjrtimmer commented Jul 23, 2018

gjrtimmer commented Jul 24, 2018

mattn commented Jul 24, 2018

gjrtimmer commented Jul 24, 2018

mattn commented Jul 24, 2018 •

edited

Loading

gjrtimmer commented Jul 24, 2018 •

edited

Loading

gjrtimmer commented Jul 24, 2018 •

edited

Loading

gjrtimmer commented Jul 26, 2018

mattn commented Jul 27, 2018

gjrtimmer commented Jul 27, 2018

v2.0.0 #611

v2.0.0 #611

Conversation

gjrtimmer commented Jul 20, 2018 • edited Loading

gjrtimmer commented Jul 20, 2018 • edited Loading

gjrtimmer commented Jul 20, 2018

mattn commented Jul 20, 2018

gjrtimmer commented Jul 21, 2018

mattn commented Jul 23, 2018

gjrtimmer commented Jul 23, 2018 • edited Loading

gjrtimmer commented Jul 23, 2018

gjrtimmer commented Jul 23, 2018

mattn commented Jul 23, 2018

gjrtimmer commented Jul 23, 2018

gjrtimmer commented Jul 23, 2018

gjrtimmer commented Jul 23, 2018

gjrtimmer commented Jul 24, 2018

mattn commented Jul 24, 2018

gjrtimmer commented Jul 24, 2018

mattn commented Jul 24, 2018 • edited Loading

gjrtimmer commented Jul 24, 2018 • edited Loading

gjrtimmer commented Jul 24, 2018 • edited Loading

gjrtimmer commented Jul 26, 2018

mattn commented Jul 27, 2018

gjrtimmer commented Jul 27, 2018

gjrtimmer commented Jul 20, 2018 •

edited

Loading

gjrtimmer commented Jul 20, 2018 •

edited

Loading

gjrtimmer commented Jul 23, 2018 •

edited

Loading

mattn commented Jul 24, 2018 •

edited

Loading

gjrtimmer commented Jul 24, 2018 •

edited

Loading

gjrtimmer commented Jul 24, 2018 •

edited

Loading