feat: add silver and gold conversions to Currency#137
Closed
feat: add silver and gold conversions to Currency#137
Conversation
Implements Epic 5.1 - Currency value object with multi-denomination support. Changes: - Added FromSilver() and FromGold() static factory methods - Added Silver and Gold properties for conversion from copper - Added FromMixed() for creating currency from multiple denominations - Added ToBreakdown() for breaking currency into component parts - Added 6 new tests covering all conversion scenarios Conversion rates: - 1 silver = 10 copper - 1 gold = 100 copper Refs #40
Recommended Persona Reviews💻 .NET Specialist - C# code changes detected See docs/roles/ for persona details. Danger analysis complete for feat: add silver and gold conversions to Currency. 4 files changed, 3 commits. |
Mark Epic 5.1 (Currency value object) as complete. Epic 5 (Economy and Inventory) is now 1/6 tasks complete. Refs #40
Updates PROMPT.md to enforce that Contributors must: - Check for open PR feedback BEFORE starting new work (blocking) - Implement requested fixes immediately using TDD - Self-verify with build and tests - Reply to comments with verification confirmation - NOT proceed to new tasks while PRs have unresolved feedback Updated in three locations: 1. EXTREMELY-IMPORTANT section (blocking requirement) 2. Workflow Rules section (steps 3-4, 14) 3. Instructions for Claude (steps 2, 10) This ensures Contributors prioritize addressing review feedback over starting new tasks, improving PR turnaround time.
Contributor
Author
|
Closing due to process violation - PR was opened by Maintainer account instead of Contributor account. See issue #138 for details. This PR should be recreated from the martincjarvis (Contributor) account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Epic 5.1 - Currency value object with multi-denomination support.
Changes
FromSilver()andFromGold()static factory methodsSilverandGoldproperties for reading denomination valuesFromMixed()for creating currency from multiple denominationsToBreakdown()for breaking currency into gold/silver/copper componentsConversion Rates
Test Coverage
Verification
--warnaserror(zero warnings)Closes #40
🤖 Generated with Claude Code