enhance(sidebar): make natural sort the default #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiji-flo
approved these changes
Jun 5, 2025
caugner
commented
Jun 5, 2025
| let locale = locale!("en-US").into(); | ||
| let mut options = CollatorOptions::new(); | ||
| pub static COLLATOR: CollatorBorrowed<'static> = { | ||
| let mut prefs = CollatorPreferences::from(locale!("en-US")); |
There was a problem hiding this comment.
It would be nice to use the right locale for translated content, but that's an independent enhancement.
Comment on lines
+358
to
+359
| let mut prefs = CollatorPreferences::from(locale!("en-US")); | ||
| prefs.numeric_ordering = Some(CollationNumericOrdering::True); |
There was a problem hiding this comment.
Btw in previous icu_collator versions, this was a collator option, rather than a preference.
caugner
changed the title
This was referenced Jun 5, 2025
This was referenced Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
listSubPagessidebar template to use natural sorting.Motivation
Ensures that Firefox release notes pages are properly sorted.
Additional details
Related issues and pull requests
Fixes #222.