Skip to content

MAGETWO-61422 Respect Category Top Navigation Max Depth setting #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2017
Merged

MAGETWO-61422 Respect Category Top Navigation Max Depth setting #2

merged 1 commit into from
Dec 3, 2017

Conversation

arnoudhgz
Copy link

Description

The setting Stores > Configuration > Catalog > Catalog > Category Top Navigation > Maximal Depth was actually never being used to limit the
topmenu.

Now the setting will be used as a condition for the category collection when it is fetched.

Fixed Issues

  1. Category Top Navigation / Maximal Depth configuration not working magento/magento2#7543: Category Top Navigation / Maximal Depth configuration not working

Manual testing scenarios

  1. Change the setting in the backend
  2. Refresh the invalidated cache
  3. See that the setting actually is being used

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@arnoudhgz
Respect Category Top Navigation Max Depth setting
5808cb2 
The setting `Stores > Configuration > Catalog > Catalog > Category Top
Navigation > Maximal Depth` was actually never being used to limit the
topmenu.

Now the setting will be used as a condition for the category collection when it is fetched.
@arnoudhgz arnoudhgz requested review from jitze and ksangers December 1, 2017 14:23
@arnoudhgz arnoudhgz merged commit 3fbca20 into mediact:bugfix/MAGETWO-61422-category-max-depth-configuration Dec 3, 2017
arnoudhgz pushed a commit that referenced this pull request Dec 7, 2017
@tzyganu
Merge pull request #2 from magento/develop
3391728 
get latest develop from upstream
arnoudhgz pushed a commit that referenced this pull request Dec 7, 2017
rename module #2
13f8919
jasperzeinstra pushed a commit that referenced this pull request Jan 2, 2019
@speedy008
Merge pull request #2 from magento/2.2-develop
301d73d 
2.2 develop-update
jasperzeinstra pushed a commit that referenced this pull request Jan 2, 2019
@markshust
Merge pull request #2 from magento/2.2-develop
99a616d 
Updating repo
jasperzeinstra pushed a commit that referenced this pull request Jan 2, 2019
@Dharmeshvaja91
Merge pull request #2 from magento/2.3-develop
c0d3480 
Update Magento
jasperzeinstra pushed a commit that referenced this pull request Jan 2, 2019
@suryakant-krish
Merge pull request #2 from magento/2.3-develop
9143820 
Branch Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitze jitze jitze approved these changes

@ksangers ksangers ksangers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnoudhgz @jitze @ksangers