Respect Category Top Navigation Max Depth setting #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ksangers and @lenlorijn the original PR to Magento was this one: magento#12528 It received feedback and now I want to create a PR again, but now on the |
The setting `Stores > Configuration > Catalog > Catalog > Category Top Navigation > Maximal Depth` was actually never being used to limit the topmenu. Now the setting will be used as a condition for the category collection when it is fetched.
ksangers
approved these changes
Dec 10, 2017
lenlorijn
reviewed
Dec 11, 2017
|
|
||
| /** | ||
| * Category resource collection | ||
| * | ||
| * @api | ||
| * @author Magento Core Team <[email protected]> | ||
| * @SuppressWarnings(PHPMD.CouplingBetweenObjects) |
There was a problem hiding this comment.
How come SuppressWarnings wasn't necessary before, but is now?
There was a problem hiding this comment.
Because this class had no DI on its own before, it relied on its parent __construct. Since I added one dependency that is not in its parent I had to add the complete __construct what triggered the PHPMD to fail on Travis-CI.
lenlorijn
merged commit 0a6ac4c
into
mediact:bugfix/MAGETWO-61422-category-max-depth-configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The setting
Stores > Configuration > Catalog > Catalog > Category Top Navigation > Maximal Depthwas actually never being used to limit the top menu maximum depth.Now the setting will be used as a condition for the category collection when it is fetched.
Fixed Issues
Manual testing scenarios
Contribution checklist