Skip to content

Feature reference audit: search parameters #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

guimachiavelli
Copy link
Member

Proposals:

  1. each parameter's description begins by listing the parameter name, its expected value and default values;
  2. move the general search parameters examples from the bottom of the page to just below the table of contents;
  3. add a warning stating that parameters must be URL-encoded when using the GET endpoint directly without an SDK (information verified with @curquiza).

…their expected

values and examples more consistent and clear
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shifu examples are bad at showcasing the features. The most clear example is attributeToHighlight where you have to scroll to see the actual highlight.

It might be interesting to reconsider the film used for the example

Comment on lines 55 to 71
```json
{
"hits": [
{
"id":"50393",
"title":"Kung Fu Panda Holiday",
"poster":"https://image.tmdb.org/t/p/w500/rV77WxY35LuYLOuQvBeD1nyWMuI.jpg",
"overview":"The Winter Feast is Po's favorite holiday. Every year he and his father hang decorations, cook together, and serve noodle soup to the villagers. But this year Shifu informs Po that as Dragon Warrior, it is his duty to host the formal Winter Feast at the Jade Palace. Po is caught between his obligations as the Dragon Warrior and his family traditions: between Shifu and Mr. Ping.",
"release_date":1290729600,
"genres":["Animation","Family","TV Movie"]
},
],
"query":"shifu"
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example is very long, I regret using that one. If you want to use a smaller one I think it would be more clear on first sight

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are discussing decoupling examples from the movies.json dataset, so that anything outside e.g. the Quick Start tutorial refers to a non-existent dataset. This would allow us to have very focussed examples; the above bit, for instance, could be abbreviated to:

    {
      "id":"50393",
      "title":"Kung Fu Panda Holiday",
      "overview":"  <em>Shifu</em> informs Po that as Dragon Warrior, it is his duty to host the formal Winter Feast at the Jade Palace.",
      "genres":["Animation","Family","TV Movie"]
    }

@guimachiavelli guimachiavelli linked an issue Jul 6, 2021 that may be closed by this pull request
@guimachiavelli
Copy link
Member Author

Closing this in favour of #1027

@guimachiavelli guimachiavelli deleted the reference-audit-parameters branch July 20, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples, datasets, and movies
2 participants