-
Notifications
You must be signed in to change notification settings - Fork 264
v0.21: update .code-samples.meilisearch.yaml
#1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.21: update .code-samples.meilisearch.yaml
#1025
Conversation
update curl examples, update names, change search parameter Matches example
✔️ Deploy Preview for distracted-wiles-3edfc5 ready! 🔨 Explore the source changes: 06b6f25 🔍 Inspect the deploy log: https://app.netlify.com/sites/distracted-wiles-3edfc5/deploys/60ed44dbb2d1a500070cfde5 😎 Browse the preview: https://deploy-preview-1025--distracted-wiles-3edfc5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Faceted search guide
If the guide on faceted search should have a name change before the release, ID's should be updated accordingly.
For example this ID:
faceted_search_facet_filters_1
Highlight and matches shifu
examples
Finally, search_parameter_guide_matches_1 has been altered
Highlight example should also be updated, because of this:
sample update:
search_parameter_guide_highlight_1: |-
curl 'http://localhost:7700/indexes/movies/search' \
--data '{ "q": "winter feast", "attributesToHighlight": ["overview"] }'
Yes good point, thank you @bidoubiwa ! I will update
This ID has already been changed to
|
Add new sample for phrase search and update highlighting sample so that highlighting occurs closer to the start of the value (more clear)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change the response bodies of both highlight
and matches
because it seems to be the appropriated PR to do so.
This is the file:
https://github.com/meilisearch/documentation/blob/master/reference/features/search_parameters.md
See my previous comment for the body to use.
Think it might be easier if @guimachiavelli reopens his PR #1016 in a new branch based off of the |
Examples previously using
|
Mistaken for |
Co-authored-by: cvermand <[email protected]>
Co-authored-by: cvermand <[email protected]>
@meilisearch/integration-team , you can use this PR as a model for updating the Please also:
|
Hello ! |
In this PR
The following changes from v0.21 are reflected here:
attributesForFaceting
changed tofilterableAttributes
Rename attributesForFaceting into filterableAttributes transplant#187filters
changed tofilter
filters and facetsFilters transplant#81facetFilters
removed and replaced withfilter
^ same as abovewordsPosition
ranking rule removed integrate the new rankingRules transplant#85typo
ranking rule drops one position in the default order ^ same as aboveIn addition, several samples have had their ID updated:
get_attributes_for_faceting_1
->get_filterable_attributes_1
update_attributes_for_faceting_1
->update_filterable_attributes_1
reset_attributes_for_faceting_1
->reset_filterable_attributes_1
faceted_search_walkthrough_attributes_for_faceting_1
->faceted_search_walkthrough_filterable_attributes_1
faceted_search_facet_filters_1
->faceted_search_filter_1
faceted_search_walkthrough_facet_filters_1
->faceted_search_walkthrough_filter_1
search_parameter_guide_matches_1
andsearch_parameter_guide_highlight_1
have been altered: the query has been changed fromshifu
towinter feast
and highlighting has been removed from the former. The former is because the terms occur earlier in the value, making it a better demonstration of matches and highlighting, and the latter is because we don't want to encourage using bothmatches
andattributesToHighlight
at the same time—one is sufficient for most use-cases.Finally, a brand new sample has been added to demonstrate the use of Phrase Search:
phrase_search_1
.For @meilisearch/integration-team
In addition to making the equivalent changes in each of the SDKs, please make sure to:
add_movies_json_1
sample to Rustsearch_parameter_guide_matches_1
. There should be nofilter
norattributesToHighlight
present here.For @guimachiavelli
<CodeSamples id="phrase_search_1" />
, into your phrase search PR