-
Notifications
You must be signed in to change notification settings - Fork 18
Fix geo point with tests #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the import plugin doesn't support `exports` property in package.json so it doesn't see newer firebase-admin exports. eslint-import-resolver-typescript fixes this
Hey @oplik0 Thanks a lot for this contribution 🙏 |
Well, turns out there are two simple solutions:
For now I decided to follow Jest recommendations and commit the snapshot files. Please let me know if you prefer to leave them ignored. The tests all pass now: https://github.com/oplik0/firestore-meilisearch/actions/runs/4223949285 |
Good for me :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 🔥
bors merge |
Build succeeded: |
Pull Request
Related issue
Fixes #143
What does this PR do?
adaptFields
adaptFields
to align with testsexports
inpackage.json
which marked allfirebase-admin
imports as lint errors.PR checklist
Please check if your PR fulfills the following requirements: