Fix _geo point not being correctly parsed #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meili-bors bot
added a commit
that referenced
this pull request
Feb 20, 2023
154: Fix geo point with tests r=bidoubiwa a=oplik0 # Pull Request ## Related issue Fixes #143 ## What does this PR do? - this is a corrected version of #147 - the issue with tests was a Jest issue that appears to have been fixed in v28. - While experimenting with this, I also updated the firebase packages - decided to leave them at newer versions instead of rolling these changes back - Made some small changes to tests to align them with output format of `adaptFields` - Re-added logging geopoint information to `adaptFields` to align with tests - Added eslint-import-resolver-typescript, because without it the eslint import plugin doesn't work with `exports` in `package.json` which marked all `firebase-admin` imports as lint errors. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Co-authored-by: oplik0 <[email protected]>
bidoubiwa
added
the
skip-changelog
the import plugin doesn't support `exports` property in package.json so it doesn't see newer firebase-admin exports. eslint-import-resolver-typescript fixes this
bidoubiwa
force-pushed
the
fix_geo_point
branch
from
c605539 to
1fdb61e
Compare
bidoubiwa
added
breaking-change
bidoubiwa
commented
Feb 20, 2023
bidoubiwa
force-pushed
the
fix_geo_point
branch
from
9c9fb01 to
bf2ba8b
Compare
alallema
reviewed
Feb 20, 2023
| @@ -0,0 +1,118 @@ | |||
| 'use strict' | |||
| /* | |||
| * Copyright 2022 Meilisearch | |||
There was a problem hiding this comment.
Do we have to change this every year?
There was a problem hiding this comment.
Good question, I looked at other plugins and they don't have that disclaimer on top of the file. Im opining an issue to remove them
…isearch into fix_geo_point
bidoubiwa
force-pushed
the
fix_geo_point
branch
from
bf2ba8b to
342e4ff
Compare
|
bors merge |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #143
If a user provides a field named
_geowith aGeoPointtype, the type will be transformed into a Meilisearch geopoint compatible format.In firestore:
In Meilisearch it becomes: