-
Notifications
You must be signed in to change notification settings - Fork 102
Update max version of go to 1.24 in pipeline #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Go versions used in the GitHub Actions workflow matrices for integration and pre-release tests have been updated. Both workflows now test against Go 1.16 and Go 1.24, replacing the previous use of Go 1.17 with Go 1.24. No other workflow logic or configuration was changed. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Go 1.16
participant Go 1.24
GitHub Actions->>Go 1.16: Run integration/pre-release tests
GitHub Actions->>Go 1.24: Run integration/pre-release tests
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
=======================================
Coverage 84.96% 84.96%
=======================================
Files 17 17
Lines 3106 3106
=======================================
Hits 2639 2639
Misses 335 335
Partials 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/pre-release-tests.yml (1)
17-22
: Re-evaluate need for legacy Go 1.16 in the matrixGo 1.16 has been out of security support for years. Unless the library explicitly guarantees compatibility that far back, keeping it in CI only lengthens runtimes and can block use of newer language features.
Consider bumping the “current” slot to the minimum version in go.mod (e.g. 1.20+) and retaining 1.24 as “latest”.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/pre-release-tests.yml
(1 hunks).github/workflows/tests.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: integration-tests (go current version)
- GitHub Check: integration-tests (go latest version)
🔇 Additional comments (1)
.github/workflows/tests.yml (1)
40-45
: Ensuresetup-go@v5
already publishes Go 1.24
actions/setup-go
needs the official 1.24 manifest; otherwise the job will fail with “version not found”. Please confirm via a dry-run or action release notes before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Pull Request
Related issue
Fixes #653
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit