Skip to content

Update max version of go to 1.24 in pipeline #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025

Conversation

ja7ad
Copy link
Collaborator

@ja7ad ja7ad commented Jul 31, 2025

Pull Request

Related issue

Fixes #653

What does this PR do?

  • This PR change max version of golang to 1.24 for pipelines

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Summary by CodeRabbit

  • Chores
    • Updated integration test workflows to use Go versions 1.16 and 1.24 for testing.

@ja7ad ja7ad requested a review from curquiza July 31, 2025 12:44
Copy link

coderabbitai bot commented Jul 31, 2025

Walkthrough

The Go versions used in the GitHub Actions workflow matrices for integration and pre-release tests have been updated. Both workflows now test against Go 1.16 and Go 1.24, replacing the previous use of Go 1.17 with Go 1.24. No other workflow logic or configuration was changed.

Changes

Cohort / File(s) Change Summary
Workflow Go Version Matrix Update
.github/workflows/pre-release-tests.yml, .github/workflows/tests.yml
Updated Go version matrix from 1.16/1.17 to 1.16/1.24; adjusted tag labels accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub Actions
    participant Go 1.16
    participant Go 1.24

    GitHub Actions->>Go 1.16: Run integration/pre-release tests
    GitHub Actions->>Go 1.24: Run integration/pre-release tests
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Assessment against linked issues

Objective Addressed Explanation
Update Go version in GitHub workflows from 1.17 to 1.24 (#653)

Poem

The matrix hops from old to new,
Go 1.24 now joins the crew!
Workflows leap with nimble grace,
Ensuring builds keep up the pace.
With every test, this rabbit cheers—
Our code now runs with fewer fears!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.96%. Comparing base (bc01982) to head (2ce94aa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   84.96%   84.96%           
=======================================
  Files          17       17           
  Lines        3106     3106           
=======================================
  Hits         2639     2639           
  Misses        335      335           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/workflows/pre-release-tests.yml (1)

17-22: Re-evaluate need for legacy Go 1.16 in the matrix

Go 1.16 has been out of security support for years. Unless the library explicitly guarantees compatibility that far back, keeping it in CI only lengthens runtimes and can block use of newer language features.

Consider bumping the “current” slot to the minimum version in go.mod (e.g. 1.20+) and retaining 1.24 as “latest”.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 729a94c and a18a256.

📒 Files selected for processing (2)
  • .github/workflows/pre-release-tests.yml (1 hunks)
  • .github/workflows/tests.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: integration-tests (go current version)
  • GitHub Check: integration-tests (go latest version)
🔇 Additional comments (1)
.github/workflows/tests.yml (1)

40-45: Ensure setup-go@v5 already publishes Go 1.24

actions/setup-go needs the official 1.24 manifest; otherwise the job will fail with “version not found”. Please confirm via a dry-run or action release notes before merging.

@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Jul 31, 2025
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@curquiza curquiza merged commit f997d1c into meilisearch:main Jul 31, 2025
5 checks passed
@ja7ad ja7ad deleted the fix/max-version-pipeline branch July 31, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Bump Go to the latest version in GitHub workflows
2 participants