Skip to content

Cleaning and removing duplicate code #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alallema opened this issue Jan 17, 2022 · 0 comments
Closed

Cleaning and removing duplicate code #315

alallema opened this issue Jan 17, 2022 · 0 comments
Assignees
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)

Comments

@alallema
Copy link
Contributor

The Java client has been completely rewritten by a contributor to use an API based on ServiceTemplate #154.

This refactoring was never implemented because it would have brought too many constraints to the use of this SDK. However, a large part of the code base of this refactor is still present in the SDK in the src/main/java/com/meilisearch/sdk/api folder.

The code has been kept since for different reasons:

  • the new code base is of very good quality
  • we don't have enough time to consider a refactor and cleanup of the codebase

A refactor of this SDK is cleaning is therefore essential, it makes us lose time during the release because the code is duplicated in some places. It would be necessary to recover the code of the API Service Template and to apply it to the SDK already present which functions while keeping the ease of use.

@alallema alallema self-assigned this Jan 17, 2022
@alallema alallema added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

No branches or pull requests

1 participant