Skip to content

Remove duplicate code #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2022
Merged

Remove duplicate code #427

merged 1 commit into from
Aug 9, 2022

Conversation

alallema
Copy link
Contributor

@alallema alallema commented Aug 9, 2022 •
edited
Loading

closed #315

A big part of the code of this SDK was duplicated and not used, this PR try to remove as much as possible.

Warning
This deletion removes some methods that only exist in this part of the code:

  • getStats
  • getHealth

@alallema alallema requested a review from brunoocasali August 9, 2022 16:26
brunoocasali
brunoocasali approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗑️

@alallema alallema merged commit f861e74 into refactor Aug 9, 2022
@alallema alallema deleted the remove_duplicate_code branch August 9, 2022 18:06
@alallema alallema mentioned this pull request Aug 10, 2022
Merged
bors bot added a commit that referenced this pull request Nov 9, 2022
@bors @alallema
Merge #425
458e631 
425: Refactorization of the SDK r=alallema a=alallema

Related to this issue: #420

**Done**
- #424
- #427 
- #428
- #432
- #439
- #438 
- #447
- #448
- #449
- #451 
- #450 
- #456
- #473
- #474
- #475
- #476

Co-authored-by: alallema <[email protected]>
Co-authored-by: Amélie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alallema @brunoocasali