Skip to content

Use OkHttpClient by default and remove the others #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alallema merged 2 commits into from
Sep 28, 2022
Merged

Use OkHttpClient by default and remove the others #449

alallema merged 2 commits into from
Sep 28, 2022

Conversation

@alallema
Copy link
Contributor

@alallema alallema commented Sep 28, 2022

No description provided.

alallema
alallema commented Sep 28, 2022
View reviewed changes
Copy link
Contributor Author

@alallema alallema left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@alallema alallema merged commit 6d63165 into refactor Sep 28, 2022
@alallema alallema deleted the clean-client branch September 28, 2022 16:27
@alallema alallema added the skip-changelog The PR will not appear in the release changelogs label Sep 28, 2022
@alallema alallema mentioned this pull request Sep 28, 2022
Merged
@alallema alallema linked an issue Oct 24, 2022 that may be closed by this pull request
Switch to a fixed HTTP client library OkHttp #419
Closed
@alallema alallema mentioned this pull request Oct 24, 2022
Closed
bors bot added a commit that referenced this pull request Nov 9, 2022
@bors @alallema
Merge #425
458e631 
425: Refactorization of the SDK r=alallema a=alallema

Related to this issue: #420

**Done**
- #424
- #427 
- #428
- #432
- #439
- #438 
- #447
- #448
- #449
- #451 
- #450 
- #456
- #473
- #474
- #475
- #476

Co-authored-by: alallema <[email protected]>
Co-authored-by: Amélie <[email protected]>
@alallema alallema added breaking-change The related changes are breaking for the users and removed skip-changelog The PR will not appear in the release changelogs labels Nov 9, 2022
@alallema alallema mentioned this pull request Nov 9, 2022
Merged
bors bot added a commit that referenced this pull request Nov 14, 2022
@bors @alallema
Merge #488
1ab0352 
488: Update version for the next release (v0.8.0) r=alallema a=alallema

This version includes a major redesign of the SDK. ([#425](#425)) [`@alallema](https://github.com/alallema)`

## ⚠️ Breaking changes

* Redesign of the client (#449) `@alallema:`
    * Use `OkHttp` library by default for the Meilisearch client
    * No interface for the creation of a Client disappearing of the class `GenericServiceTemplate`, `ServiceTemplate`, `AbstractClient`, `ApacheClient`, and `DefaultHttpClient`.
* Rename `getAllIndexes` method in `getIndexes` (#477) `@alallema`
* All parameters of the managers accessible in the client are now private: `Config`, `IndexesHandler`, `InstanceHandler`, ` TasksHandler`, `KeysHandler`, `JsonHandler`.
* Factories for the answer and the response disappeared, those classes were removed: `BasicRequestFactory`, `BasicHttpResponse`, `BasicHttpRequest`, and `MeilisearchHttpRequest`.
* Rewriting of the JsonHandler
    * Offering the possibility to use `Gson`, `Jackson` or create your own handler.([#432]
    * Remove `JsonbJsonHandler`.
* Dump returns a `Task`from v0.28.0 so the `createDump` method has been removed just as the `DumpHandler` class.
* Renaming class `Details` in `TaskDetails`
* All methods return now a `MeilisearchException` instead of a `Exception`.

## 🚀 Enhancements

* Replaced traditional getter setter by ``@Getter`` ``@Setter`` from Lombok library ([#385](#385)) [`@ghousek1](https://github.com/ghousek1)`
* Improve Docker configuration in the package ([#399](#399))
* Add code-coverage tool (jacoco) ([#422](#422)) [`@brunoocasali](https://github.com/brunoocasali)`
* Refactoring:
    * Rewriting of the Error Handler ([#438](#438)) [`@alallema](https://github.com/alallema)`
        * Like the other SDKs, this one now contains `MeilisearchApiError`, `MeiliSearchCommunicationError`, `MeilisearchTimeoutError`, `JsonDecodingException` as well as `JsonEncodingException`.
        * All methods return now a `MeilisearchException` instead of a Exception.
(#432))  [`@alallema](https://github.com/alallema)`
    * Rewrite some missing method (#473) [`@alallema](https://github.com/alallema)`
        * health()
        * isHealthy()
        * getVersion()
        * getStats()
        * index.getStats()
        * updateKey() ([#476](#476)) [`@alallema](https://github.com/alallema)`
    * Add typo tolerance settings ([#371](#371)) [`@alallema](https://github.com/alallema)`
    * Add toString method to SearchRequest Class ([#451](#451)) [`@alallema](https://github.com/alallema)`
    * Add support to PATCH HTTP method ([#472](#472)) [`@alallema](https://github.com/alallema)`


Thanks again to `@alallema,`  `@brunoocasali,`   `@ghousek1,` `@kisaga` ! 🎉


Co-authored-by: alallema <[email protected]>
Co-authored-by: Amélie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees

No one assigned

Labels

breaking-change The related changes are breaking for the users

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch to a fixed HTTP client library OkHttp

3 participants

@alallema @brunoocasali