Skip to content

Use OkHttpClient by default and remove the others #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alallema merged 2 commits into from
Sep 28, 2022
Merged

Use OkHttpClient by default and remove the others #449

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
647e7e0
Use OkHttpClient by default and remove the others
alallema Sep 28, 2022
5aca6f0
Remove library from gradle file
alallema Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/meilisearch/sdk/IndexesHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class IndexesHandler {
* @param config Meilisearch configuration
*/
IndexesHandler(Config config) {
this.meilisearchHttpRequest = new MeilisearchHttpRequest(config);
this.meilisearchHttpRequest = config.meilisearchHttpRequest;
}

/**
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/meilisearch/sdk/MeilisearchHttpRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import com.meilisearch.sdk.exceptions.MeilisearchApiException;
import com.meilisearch.sdk.exceptions.MeilisearchException;
import com.meilisearch.sdk.http.AbstractHttpClient;
import com.meilisearch.sdk.http.DefaultHttpClient;
import com.meilisearch.sdk.http.CustomOkHttpClient;
import com.meilisearch.sdk.http.factory.BasicRequestFactory;
import com.meilisearch.sdk.http.factory.RequestFactory;
import com.meilisearch.sdk.http.request.HttpMethod;
Expand All @@ -25,7 +25,7 @@ public class MeilisearchHttpRequest {
* @param config Meilisearch configuration
*/
public MeilisearchHttpRequest(Config config) {
this.client = new DefaultHttpClient(config);
this.client = new CustomOkHttpClient(config);
this.jsonHandler = config.jsonHandler;
this.factory = new BasicRequestFactory(jsonHandler);
}
Expand Down
114 changes: 0 additions & 114 deletions src/main/java/com/meilisearch/sdk/http/ApacheHttpClient.java
View file
Open in desktop

This file was deleted.

107 changes: 0 additions & 107 deletions src/main/java/com/meilisearch/sdk/http/DefaultHttpClient.java
View file
Open in desktop

This file was deleted.

Loading