Refactorization of the SDK #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
requested review from
brunoocasali
and removed request for
brunoocasali
Renaming last MeiliSearch to Meilisearch
Co-authored-by: Bruno Casali <[email protected]>
Rewriting of the error handler
Co-authored-by: Bruno Casali <[email protected]>
bidoubiwa
reviewed
Nov 8, 2022
Co-authored-by: cvermand <[email protected]>
Co-authored-by: cvermand <[email protected]>
Co-authored-by: cvermand <[email protected]>
Co-authored-by: cvermand <[email protected]>
bidoubiwa
reviewed
Nov 8, 2022
Co-authored-by: cvermand <[email protected]>
alallema
force-pushed
the
refactor
branch
3 times, most recently
from
63ac522 to
b88e921
Compare
|
What an interesting PR here 👀 😇 |
brunoocasali
approved these changes
Nov 9, 2022
|
bors merge |
|
Build succeeded:
|
This was referenced Nov 9, 2022
bors bot
added a commit
that referenced
this pull request
Nov 14, 2022
488: Update version for the next release (v0.8.0) r=alallema a=alallema This version includes a major redesign of the SDK. ([#425](#425)) [`@alallema](https://github.com/alallema)` ##⚠️ Breaking changes * Redesign of the client (#449) `@alallema:` * Use `OkHttp` library by default for the Meilisearch client * No interface for the creation of a Client disappearing of the class `GenericServiceTemplate`, `ServiceTemplate`, `AbstractClient`, `ApacheClient`, and `DefaultHttpClient`. * Rename `getAllIndexes` method in `getIndexes` (#477) `@alallema` * All parameters of the managers accessible in the client are now private: `Config`, `IndexesHandler`, `InstanceHandler`, ` TasksHandler`, `KeysHandler`, `JsonHandler`. * Factories for the answer and the response disappeared, those classes were removed: `BasicRequestFactory`, `BasicHttpResponse`, `BasicHttpRequest`, and `MeilisearchHttpRequest`. * Rewriting of the JsonHandler * Offering the possibility to use `Gson`, `Jackson` or create your own handler.([#432] * Remove `JsonbJsonHandler`. * Dump returns a `Task`from v0.28.0 so the `createDump` method has been removed just as the `DumpHandler` class. * Renaming class `Details` in `TaskDetails` * All methods return now a `MeilisearchException` instead of a `Exception`. ## 🚀 Enhancements * Replaced traditional getter setter by ``@Getter`` ``@Setter`` from Lombok library ([#385](#385)) [`@ghousek1](https://github.com/ghousek1)` * Improve Docker configuration in the package ([#399](#399)) * Add code-coverage tool (jacoco) ([#422](#422)) [`@brunoocasali](https://github.com/brunoocasali)` * Refactoring: * Rewriting of the Error Handler ([#438](#438)) [`@alallema](https://github.com/alallema)` * Like the other SDKs, this one now contains `MeilisearchApiError`, `MeiliSearchCommunicationError`, `MeilisearchTimeoutError`, `JsonDecodingException` as well as `JsonEncodingException`. * All methods return now a `MeilisearchException` instead of a Exception. (#432)) [`@alallema](https://github.com/alallema)` * Rewrite some missing method (#473) [`@alallema](https://github.com/alallema)` * health() * isHealthy() * getVersion() * getStats() * index.getStats() * updateKey() ([#476](#476)) [`@alallema](https://github.com/alallema)` * Add typo tolerance settings ([#371](#371)) [`@alallema](https://github.com/alallema)` * Add toString method to SearchRequest Class ([#451](#451)) [`@alallema](https://github.com/alallema)` * Add support to PATCH HTTP method ([#472](#472)) [`@alallema](https://github.com/alallema)` Thanks again to `@alallema,` `@brunoocasali,` `@ghousek1,` `@kisaga` ! 🎉 Co-authored-by: alallema <[email protected]> Co-authored-by: Amélie <[email protected]>
This was referenced Feb 23, 2023
meili-bors bot
added a commit
that referenced
this pull request
May 9, 2023
594: Add explicitly requirement of okhttp r=alallema a=brunoocasali Since the reported error is just a misconfiguration, I believe we can fix it by always making the lib required since that's true after the refactor #425. Fix #580 Co-authored-by: Bruno Casali <[email protected]> Co-authored-by: Amélie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue: #420
Done
jsonHandlerand reduce the use to oneJSONlibrary #432