Add explicitly requirement of okhttp #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
reviewed
May 9, 2023
There was a problem hiding this comment.
Thanks, @brunoocasali for this PR
LGTM!
cf: I fix some conflict due to bump merge
alallema
approved these changes
May 9, 2023
|
bors merge |
|
Build succeeded: |
meili-bors bot
added a commit
that referenced
this pull request
May 9, 2023
598: Update version for the next release (v0.11.1) r=alallema a=meili-bot ## 🚀 Enhancements * Add support to the pagination setting customization at the index level (#568) `@dennxa` * `getPaginationSettings` * `updatePaginationSettings` * `resetPaginationSettings` * Create an enum to handle the Task Status (#566) `@TheClerici` * Add support to the sortable attributes settings (#570) `@albajarazeth` * `getSortableAttributesSettings` * `updateSortableAttributesSettings` * `resetSortableAttributesSettings` * Add support to the faceting setting customization at the index level (#577) `@MaAnCoSa` * `getFacetingSettings` * `updateFacetingSettings` * `resetFacetingSettings` * Add explicitly requirement of `okhttp` library (#594) `@brunoocasali` * Update Gradle tooling (#596) `@brunoocasali` Thanks again to `@MaAnCoSa,` `@PotatoDoge,` `@TheClerici,` `@alallema,` `@albajarazeth,` `@brunoocasali,` `@curquiza,` `@dennxa` and `@oraliahdz` 🎉 Co-authored-by: meili-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the reported error is just a misconfiguration, I believe we can fix it by always making the lib required since that's true after the refactor #425.
Fix #580