Skip to content

Move MeilisearchHttpClient to Config #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alallema merged 1 commit into from
Sep 28, 2022
Merged

Move MeilisearchHttpClient to Config #448

alallema merged 1 commit into from
Sep 28, 2022

Conversation

@alallema
Copy link
Contributor

@alallema alallema commented Sep 28, 2022

The MeilisearchHttpClient variable has been moved to the Config class in a way to be instantiated once instead of being created in each Handler.

alallema
alallema commented Sep 28, 2022
View reviewed changes
Copy link
Contributor Author

@alallema alallema left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@alallema alallema changed the title Move HttpClient to Config Move MeilisearchHttpClient to Config Sep 28, 2022
@alallema alallema merged commit 9549251 into refactor Sep 28, 2022
@alallema alallema deleted the http-client-in-config branch September 28, 2022 14:52
@alallema alallema mentioned this pull request Sep 28, 2022
Merged
bors bot added a commit that referenced this pull request Nov 9, 2022
@bors @alallema
Merge #425
458e631 
425: Refactorization of the SDK r=alallema a=alallema

Related to this issue: #420

**Done**
- #424
- #427 
- #428
- #432
- #439
- #438 
- #447
- #448
- #449
- #451 
- #450 
- #456
- #473
- #474
- #475
- #476

Co-authored-by: alallema <[email protected]>
Co-authored-by: Amélie <[email protected]>
@alallema alallema added skip-changelog The PR will not appear in the release changelogs maintenance Anything related to maintenance (CI, tests, refactoring...) labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees

No one assigned

Labels

maintenance Anything related to maintenance (CI, tests, refactoring...) skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alallema @brunoocasali