Skip to content

Revision Java SDK #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alallema opened this issue Aug 2, 2022 · 0 comments · Fixed by #425
Closed

Revision Java SDK #420

alallema opened this issue Aug 2, 2022 · 0 comments · Fixed by #425
Assignees
@alallema
Labels
breaking-change The related changes are breaking for the users

Comments

@alallema
Copy link
Contributor

alallema commented Aug 2, 2022 •
edited
Loading

Description
Following a refactor attempt made some time ago the Java SDK has kept duplicate code and builders that are not fully functional. This makes the code quite complicated to maintain and difficult to access for contributions and reviews.
See more details #315

What we planned to do

PR related
@alallema alallema added the breaking-change The related changes are breaking for the users label Aug 2, 2022
@alallema alallema self-assigned this Aug 2, 2022
@alallema alallema mentioned this issue Aug 4, 2022
Merged
@alallema alallema linked a pull request Oct 24, 2022 that will close this issue
Refactorization of the SDK #425
Merged
This was referenced Oct 27, 2022
Open
Closed
Open
bors bot added a commit that referenced this issue Nov 9, 2022
@bors @alallema
Merge #425
458e631 
425: Refactorization of the SDK r=alallema a=alallema

Related to this issue: #420

**Done**
- #424
- #427 
- #428
- #432
- #439
- #438 
- #447
- #448
- #449
- #451 
- #450 
- #456
- #473
- #474
- #475
- #476

Co-authored-by: alallema <[email protected]>
Co-authored-by: Amélie <[email protected]>
@bors bors bot closed this as completed in #425 Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alallema alallema

Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactorization of the SDK meilisearch/meilisearch-java
1 participant
@alallema