Rewriting of the error handler #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
That was an awesome work @alallema 🎉
I just left some comments for you ;)
|
|
||
| @Override | ||
| public String toString() { | ||
| return "APIError: {" |
There was a problem hiding this comment.
I have some different feelings when I see this haha, but I don't know to improve it :|
There was a problem hiding this comment.
Me neither it was already like this ...
| // todo: throw dedicated exception | ||
| throw new Exception(e); | ||
| } catch (Exception e) { | ||
| throw new MeilisearchException(e); |
There was a problem hiding this comment.
Maybe use a MeilisearchApiException here?
There was a problem hiding this comment.
I'm not sure about this comment anymore to be honest
There was a problem hiding this comment.
The ApacheHttpClient will be removed so I admit that I didn't spend too much time on it
src/main/java/com/meilisearch/sdk/exceptions/MeilisearchCommunicationException.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Bruno Casali <[email protected]>
Closed
This was referenced Oct 13, 2022
Closed
Closed
bors bot
added a commit
that referenced
this pull request
Nov 14, 2022
488: Update version for the next release (v0.8.0) r=alallema a=alallema This version includes a major redesign of the SDK. ([#425](#425)) [`@alallema](https://github.com/alallema)` ##⚠️ Breaking changes * Redesign of the client (#449) `@alallema:` * Use `OkHttp` library by default for the Meilisearch client * No interface for the creation of a Client disappearing of the class `GenericServiceTemplate`, `ServiceTemplate`, `AbstractClient`, `ApacheClient`, and `DefaultHttpClient`. * Rename `getAllIndexes` method in `getIndexes` (#477) `@alallema` * All parameters of the managers accessible in the client are now private: `Config`, `IndexesHandler`, `InstanceHandler`, ` TasksHandler`, `KeysHandler`, `JsonHandler`. * Factories for the answer and the response disappeared, those classes were removed: `BasicRequestFactory`, `BasicHttpResponse`, `BasicHttpRequest`, and `MeilisearchHttpRequest`. * Rewriting of the JsonHandler * Offering the possibility to use `Gson`, `Jackson` or create your own handler.([#432] * Remove `JsonbJsonHandler`. * Dump returns a `Task`from v0.28.0 so the `createDump` method has been removed just as the `DumpHandler` class. * Renaming class `Details` in `TaskDetails` * All methods return now a `MeilisearchException` instead of a `Exception`. ## 🚀 Enhancements * Replaced traditional getter setter by ``@Getter`` ``@Setter`` from Lombok library ([#385](#385)) [`@ghousek1](https://github.com/ghousek1)` * Improve Docker configuration in the package ([#399](#399)) * Add code-coverage tool (jacoco) ([#422](#422)) [`@brunoocasali](https://github.com/brunoocasali)` * Refactoring: * Rewriting of the Error Handler ([#438](#438)) [`@alallema](https://github.com/alallema)` * Like the other SDKs, this one now contains `MeilisearchApiError`, `MeiliSearchCommunicationError`, `MeilisearchTimeoutError`, `JsonDecodingException` as well as `JsonEncodingException`. * All methods return now a `MeilisearchException` instead of a Exception. (#432)) [`@alallema](https://github.com/alallema)` * Rewrite some missing method (#473) [`@alallema](https://github.com/alallema)` * health() * isHealthy() * getVersion() * getStats() * index.getStats() * updateKey() ([#476](#476)) [`@alallema](https://github.com/alallema)` * Add typo tolerance settings ([#371](#371)) [`@alallema](https://github.com/alallema)` * Add toString method to SearchRequest Class ([#451](#451)) [`@alallema](https://github.com/alallema)` * Add support to PATCH HTTP method ([#472](#472)) [`@alallema](https://github.com/alallema)` Thanks again to `@alallema,` `@brunoocasali,` `@ghousek1,` `@kisaga` ! 🎉 Co-authored-by: alallema <[email protected]> Co-authored-by: Amélie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
This PR tries to clean and organize the exceptions by following this guide meilisearch/integration-guides#19
PR checklist
ExceptionNotes
The duplication of code on
HTTPmethods in theMeilisearchHttpResquestandCustomOKHttpfiles will be treated in a PR linked to the client's refacto