Add typo tolerance settings #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
reviewed
May 4, 2022
5 tasks
brunoocasali
reviewed
May 5, 2022
brunoocasali
reviewed
May 5, 2022
brunoocasali
reviewed
May 5, 2022
There was a problem hiding this comment.
This time I could review the tests, awesome work @alallema :D
|
|
||
| @Test | ||
| @DisplayName("Test update typo tolerance settings") | ||
| public void testUpdateTypoTolerance() throws Exception { |
There was a problem hiding this comment.
Can you change this test (or add another) with the update of just a couple of fields like only setDisableOnAttributes and minWordSizeTypos? Just to ensure all the other fields remain the same (because the update is partial)
There was a problem hiding this comment.
I have already checked this field. Do you mean to check it before the update?
There was a problem hiding this comment.
The assertions phase is great, I mean the exercise part is my point.
Your test is perfect as well, I just would like to have another test that is more "real-life", which means in real life the users may not update all the fields at once like the test is doing, they maybe just change one or two, and my suggestion is to have test with this kind of case.
I don't know if it was clear enough, but let me know!
There was a problem hiding this comment.
btw @alallema this is the last comment, after this I'll approve it 👯
Co-authored-by: Bruno Casali <[email protected]>
|
bors merge |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Nov 14, 2022
488: Update version for the next release (v0.8.0) r=alallema a=alallema This version includes a major redesign of the SDK. ([#425](#425)) [`@alallema](https://github.com/alallema)` ##⚠️ Breaking changes * Redesign of the client (#449) `@alallema:` * Use `OkHttp` library by default for the Meilisearch client * No interface for the creation of a Client disappearing of the class `GenericServiceTemplate`, `ServiceTemplate`, `AbstractClient`, `ApacheClient`, and `DefaultHttpClient`. * Rename `getAllIndexes` method in `getIndexes` (#477) `@alallema` * All parameters of the managers accessible in the client are now private: `Config`, `IndexesHandler`, `InstanceHandler`, ` TasksHandler`, `KeysHandler`, `JsonHandler`. * Factories for the answer and the response disappeared, those classes were removed: `BasicRequestFactory`, `BasicHttpResponse`, `BasicHttpRequest`, and `MeilisearchHttpRequest`. * Rewriting of the JsonHandler * Offering the possibility to use `Gson`, `Jackson` or create your own handler.([#432] * Remove `JsonbJsonHandler`. * Dump returns a `Task`from v0.28.0 so the `createDump` method has been removed just as the `DumpHandler` class. * Renaming class `Details` in `TaskDetails` * All methods return now a `MeilisearchException` instead of a `Exception`. ## 🚀 Enhancements * Replaced traditional getter setter by ``@Getter`` ``@Setter`` from Lombok library ([#385](#385)) [`@ghousek1](https://github.com/ghousek1)` * Improve Docker configuration in the package ([#399](#399)) * Add code-coverage tool (jacoco) ([#422](#422)) [`@brunoocasali](https://github.com/brunoocasali)` * Refactoring: * Rewriting of the Error Handler ([#438](#438)) [`@alallema](https://github.com/alallema)` * Like the other SDKs, this one now contains `MeilisearchApiError`, `MeiliSearchCommunicationError`, `MeilisearchTimeoutError`, `JsonDecodingException` as well as `JsonEncodingException`. * All methods return now a `MeilisearchException` instead of a Exception. (#432)) [`@alallema](https://github.com/alallema)` * Rewrite some missing method (#473) [`@alallema](https://github.com/alallema)` * health() * isHealthy() * getVersion() * getStats() * index.getStats() * updateKey() ([#476](#476)) [`@alallema](https://github.com/alallema)` * Add typo tolerance settings ([#371](#371)) [`@alallema](https://github.com/alallema)` * Add toString method to SearchRequest Class ([#451](#451)) [`@alallema](https://github.com/alallema)` * Add support to PATCH HTTP method ([#472](#472)) [`@alallema](https://github.com/alallema)` Thanks again to `@alallema,` `@brunoocasali,` `@ghousek1,` `@kisaga` ! 🎉 Co-authored-by: alallema <[email protected]> Co-authored-by: Amélie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIPit will be merged after the v0.27.0This PR introduces the new setting: typoTolerance
new methods:
index.getTypoTolerance()index.updateTypoTolerance(params)index.resetTypoTolerance()