Skip to content

Update version for the next release (v0.9.0) #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

alallema
Copy link
Contributor

@alallema alallema commented Jan 17, 2023

💥 Breaking Changes

🚀 Enhancements

Thanks again to @alallema, @brunoocasali ! 🎉

@alallema alallema marked this pull request as ready for review January 17, 2023 13:27
@alallema alallema requested a review from brunoocasali January 17, 2023 13:27
@brunoocasali
Copy link
Member

@alallema we need to add a disclaimer about the "analytics":

You can copy from here: https://github.com/meilisearch/meilisearch-dart/releases/tag/v0.5.1

@brunoocasali
Copy link
Member

Can you convert these two:

Remove GET /indexes/:indexUid/tasks. Use GET /tasks?indexUid=:indexUid instead (https://github.com/meilisearch/meilisearch-java/pull/510) @alallema
Remove GET /indexes/:indexUid/tasks/:taskUid. Use GET /tasks/:taskUid instead (https://github.com/meilisearch/meilisearch-java/pull/510) @alallema

To use the Java methods instead of the HTTP routes?

@alallema
Copy link
Contributor Author

alallema commented Jan 17, 2023

Can you convert these two:

Remove GET /indexes/:indexUid/tasks. Use GET /tasks?indexUid=:indexUid instead (https://github.com/meilisearch/meilisearch-java/pull/510) @alallema
Remove GET /indexes/:indexUid/tasks/:taskUid. Use GET /tasks/:taskUid instead (https://github.com/meilisearch/meilisearch-java/pull/510) @alallema

To use the Java methods instead of the HTTP routes?

It's because the methods didn't really changes is the route inside the method that has changed no?

@brunoocasali
Copy link
Member

There is just a small typo in the backticks here:

`GET /documents/:uid`` now the return is wrap in a result

And also, you can change it to now the method returns a Results<T> and of course, change the GET /documents/:uid to the Java method :)

@brunoocasali
Copy link
Member

Here Create two separate methods for you can omit the -> return an... because the users will understand it just by looking to the method signature you use:

Here (blue part): image

It will be like this:
image


And here In the endpoint GET /tasks we can filter by you can change to use the Java method as well :)

@brunoocasali
Copy link
Member

It's because the methods didn't really changes is the route inside the method that has changed no?

@alallema if nothing related to the method signature changed you can remove the entire change from the changelog, even if Meili stopped to accept that method, we manage to keep the same behavior, so no need to inform the user about that.

@alallema alallema force-pushed the update-release-v0.9.0 branch from 333a59e to 8c7430c Compare January 17, 2023 13:51
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥🔥

@alallema alallema merged commit fb28ab6 into main Jan 17, 2023
@alallema alallema deleted the update-release-v0.9.0 branch January 17, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants